| Message ID | 20230723044041.1089804-7-bmeng@tinylab.org |
|---|---|
| State | Accepted |
| Commit | 17cd80237b09c3926c317bd348959f057f8dec7d |
| Delegated to: | Anatolij Gustschin |
| Headers | show |
| Series | video: bochs: Remove the x86 limitation | expand |
On Sat, 22 Jul 2023 at 22:41, Bin Meng <bmeng@tinylab.org> wrote: > > There is an example in the VIDEO_PCI_DEFAULT_FB_SIZE help text to > tell people how to calculate its value but the resolution given > does not match the value. Fix it. > > Signed-off-by: Bin Meng <bmeng@tinylab.org> > --- > > drivers/video/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Sun, 23 Jul 2023 12:40:29 +0800 Bin Meng bmeng@tinylab.org wrote: > There is an example in the VIDEO_PCI_DEFAULT_FB_SIZE help text to > tell people how to calculate its value but the resolution given > does not match the value. Fix it. > > Signed-off-by: Bin Meng <bmeng@tinylab.org> > --- > > drivers/video/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) applied to u-boot-video/master, thanks! -- Anatolij
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 3cdaa5ff27..43ec7e6695 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -77,7 +77,7 @@ config VIDEO_PCI_DEFAULT_FB_SIZE devices to have a framebuffer allocated by U-Boot. Note: the framebuffer needs to be large enough to store all pixels at - maximum resolution. For example, at 1920 x 1200 with 32 bits per + maximum resolution. For example, at 2560 x 1600 with 32 bits per pixel, 2560 * 1600 * 32 / 8 = 0xfa0000 bytes are needed. config VIDEO_COPY @@ -1049,7 +1049,7 @@ config SPL_VIDEO_PCI_DEFAULT_FB_SIZE devices to have a framebuffer allocated by U-Boot. Note: the framebuffer needs to be large enough to store all pixels at - maximum resolution. For example, at 1920 x 1200 with 32 bits per + maximum resolution. For example, at 2560 x 1600 with 32 bits per pixel, 2560 * 1600 * 32 / 8 = 0xfa0000 bytes are needed. config SPL_CONSOLE_SCROLL_LINES
There is an example in the VIDEO_PCI_DEFAULT_FB_SIZE help text to tell people how to calculate its value but the resolution given does not match the value. Fix it. Signed-off-by: Bin Meng <bmeng@tinylab.org> --- drivers/video/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)