diff mbox series

cmd: efidebug: add missing efi_free_pool for dh subcommand

Message ID 20230629021351.230897-1-masahisa.kojima@linaro.org
State Accepted, archived
Commit 0c95744bccea30c013cdd92c2c6afb6f96bd063a
Delegated to: Heinrich Schuchardt
Headers show
Series cmd: efidebug: add missing efi_free_pool for dh subcommand | expand

Commit Message

Masahisa Kojima June 29, 2023, 2:13 a.m. UTC
This adds the missing efi_free_pool call for dh subcommand.

Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
---
 cmd/efidebug.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ilias Apalodimas June 29, 2023, 9:08 a.m. UTC | #1
On Thu, 29 Jun 2023 at 05:14, Masahisa Kojima
<masahisa.kojima@linaro.org> wrote:
>
> This adds the missing efi_free_pool call for dh subcommand.
>
> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
> ---
>  cmd/efidebug.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/cmd/efidebug.c b/cmd/efidebug.c
> index 9622430c47..0be3af3e76 100644
> --- a/cmd/efidebug.c
> +++ b/cmd/efidebug.c
> @@ -486,6 +486,7 @@ static int do_efi_show_handles(struct cmd_tbl *cmdtp, int flag,
>                         if (guidcmp(guid[j], &efi_guid_device_path))
>                                 printf("  %pUs\n", guid[j]);
>                 }
> +               efi_free_pool(guid);
>         }
>
>         efi_free_pool(handles);
> --
> 2.34.1
>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Heinrich Schuchardt July 9, 2023, 1:30 a.m. UTC | #2
On 6/29/23 11:08, Ilias Apalodimas wrote:
> On Thu, 29 Jun 2023 at 05:14, Masahisa Kojima
> <masahisa.kojima@linaro.org> wrote:
>>
>> This adds the missing efi_free_pool call for dh subcommand.
>>

Fixes: a80146205d0a ("cmd: efidebug: add dh command")
>> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

>> ---
>>   cmd/efidebug.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/cmd/efidebug.c b/cmd/efidebug.c
>> index 9622430c47..0be3af3e76 100644
>> --- a/cmd/efidebug.c
>> +++ b/cmd/efidebug.c
>> @@ -486,6 +486,7 @@ static int do_efi_show_handles(struct cmd_tbl *cmdtp, int flag,
>>                          if (guidcmp(guid[j], &efi_guid_device_path))
>>                                  printf("  %pUs\n", guid[j]);
>>                  }
>> +               efi_free_pool(guid);
>>          }
>>
>>          efi_free_pool(handles);
>> --
>> 2.34.1
>>
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff mbox series

Patch

diff --git a/cmd/efidebug.c b/cmd/efidebug.c
index 9622430c47..0be3af3e76 100644
--- a/cmd/efidebug.c
+++ b/cmd/efidebug.c
@@ -486,6 +486,7 @@  static int do_efi_show_handles(struct cmd_tbl *cmdtp, int flag,
 			if (guidcmp(guid[j], &efi_guid_device_path))
 				printf("  %pUs\n", guid[j]);
 		}
+		efi_free_pool(guid);
 	}
 
 	efi_free_pool(handles);