diff mbox series

mkimage: Use PATH_MAX for path length

Message ID 20230619062250.3244894-1-mingli.yu@eng.windriver.com
State Accepted
Commit 99d430f344bfdb0641022fd3efa26c29c957df02
Delegated to: Tom Rini
Headers show
Series mkimage: Use PATH_MAX for path length | expand

Commit Message

mingli.yu@eng.windriver.com June 19, 2023, 6:22 a.m. UTC 
From: Mingli Yu <mingli.yu@windriver.com>

Fixed when build xilinx_zynqmp in long directory ( >256):
  |  /buildarea1/testtest/wr_build/wr1023test_secureboot/test1-what/test2-what/test3-what/test4-what/test5-what/test6-what/test7-what/test8-what/test9-what/test10-what/test11-what/test12-what/build/tmp-glibc/work/xilinx_zynqmp-wrs-linux/u-boot-xlnx/1_v2023.01-xilinx-v2023.1+gitAUTOINC+40a08d69e7-r0/build/fitImage-linux: Image file name (uboot-mkimage) too long, can't create tmpfile.
  | Error: Bad parameters for FIT image type

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 tools/mkimage.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Tom Rini June 25, 2023, 1:38 a.m. UTC | #1 
On Mon, Jun 19, 2023 at 02:22:50PM +0800, mingli.yu@eng.windriver.com wrote:

> From: Mingli Yu <mingli.yu@windriver.com>
> 
> Fixed when build xilinx_zynqmp in long directory ( >256):
>   |  /buildarea1/testtest/wr_build/wr1023test_secureboot/test1-what/test2-what/test3-what/test4-what/test5-what/test6-what/test7-what/test8-what/test9-what/test10-what/test11-what/test12-what/build/tmp-glibc/work/xilinx_zynqmp-wrs-linux/u-boot-xlnx/1_v2023.01-xilinx-v2023.1+gitAUTOINC+40a08d69e7-r0/build/fitImage-linux: Image file name (uboot-mkimage) too long, can't create tmpfile.
>   | Error: Bad parameters for FIT image type
> 
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/tools/mkimage.h b/tools/mkimage.h
index f5ca65e2ed..d92a3ff811 100644
--- a/tools/mkimage.h
+++ b/tools/mkimage.h
@@ -17,6 +17,7 @@ 
 #include <sys/stat.h>
 #include <time.h>
 #include <unistd.h>
+#include <limits.h>
 #include <u-boot/sha1.h>
 #include "fdt_host.h"
 #include "imagetool.h"
@@ -44,7 +45,7 @@  static inline ulong map_to_sysmem(void *ptr)
 #define ALLOC_CACHE_ALIGN_BUFFER(type, name, size) type name[size]
 
 #define MKIMAGE_TMPFILE_SUFFIX		".tmp"
-#define MKIMAGE_MAX_TMPFILE_LEN		256
+#define MKIMAGE_MAX_TMPFILE_LEN		PATH_MAX
 #define MKIMAGE_DEFAULT_DTC_OPTIONS	"-I dts -O dtb -p 500"
 #define MKIMAGE_MAX_DTC_CMDLINE_LEN	2 * MKIMAGE_MAX_TMPFILE_LEN + 35