diff mbox series

[v2,2/5] imx8mn-var-som: fix non-applied PHY reset-gpios properties

Message ID 20230525210228.4164480-3-hugo@hugovil.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show
Series imx8mn-var-som: fix ethernet for Variscite symphony board and imx8m nano SOM | expand

Commit Message

Hugo Villeneuve May 25, 2023, 9:02 p.m. UTC 
From: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Select DM_ETH_PHY so that the reset-gpios property of the ethphy node
can be used.

Also select DM_PCA953X, which is needed for resetting the
ethernet PHY on the carrier board via the PCA9534 I/O expander.

Commit 4e5114daf9eb ("imx8mn: synchronise device tree with linux") did
synchronise device tree with linux, which in effect removed obsolete
PHY reset properties and replaced them with new mdio DM
properties. But the commit didn't activate DM_ETH_PHY or DM_PCA953X.

Fixes: 4e5114daf9eb ("imx8mn: synchronise device tree with linux")

Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
 arch/arm/mach-imx/imx8m/Kconfig  | 1 +
 configs/imx8mn_var_som_defconfig | 1 +
 2 files changed, 2 insertions(+)

Comments

Stefano Babic July 11, 2023, 7:46 p.m. UTC | #1 
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> Select DM_ETH_PHY so that the reset-gpios property of the ethphy node
> can be used.
> Also select DM_PCA953X, which is needed for resetting the
> ethernet PHY on the carrier board via the PCA9534 I/O expander.
> Commit 4e5114daf9eb ("imx8mn: synchronise device tree with linux") did
> synchronise device tree with linux, which in effect removed obsolete
> PHY reset properties and replaced them with new mdio DM
> properties. But the commit didn't activate DM_ETH_PHY or DM_PCA953X.
> Fixes: 4e5114daf9eb ("imx8mn: synchronise device tree with linux")
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig
index 3450399d6f..a940d8a950 100644
--- a/arch/arm/mach-imx/imx8m/Kconfig
+++ b/arch/arm/mach-imx/imx8m/Kconfig
@@ -247,6 +247,7 @@  config TARGET_IMX8MN_VAR_SOM
 	select IMX8M_DDR4
 	select MISC
 	select I2C_EEPROM
+	select DM_ETH_PHY
 
 config TARGET_KONTRON_PITX_IMX8M
 	bool "Support Kontron pITX-imx8m"
diff --git a/configs/imx8mn_var_som_defconfig b/configs/imx8mn_var_som_defconfig
index f8bbdb6935..f0e232081f 100644
--- a/configs/imx8mn_var_som_defconfig
+++ b/configs/imx8mn_var_som_defconfig
@@ -77,6 +77,7 @@  CONFIG_FASTBOOT_FLASH=y
 CONFIG_FASTBOOT_UUU_SUPPORT=y
 CONFIG_FASTBOOT_FLASH_MMC_DEV=2
 CONFIG_MXC_GPIO=y
+CONFIG_DM_PCA953X=y
 CONFIG_DM_I2C=y
 CONFIG_SUPPORT_EMMC_BOOT=y
 CONFIG_MMC_IO_VOLTAGE=y