| Message ID | 20230414220645.37092-2-nm@ti.com |
|---|---|
| State | Accepted |
| Commit | 0207403eebec7f0918d84003666c30c4d0067197 |
| Delegated to: | Ramon Fried |
| Headers | show |
| Series | net: phy: phy_interface_is_rgmii update, drop phy_interface_is_sgmii | expand |
On Sat, Apr 15, 2023 at 1:06 AM Nishanth Menon <nm@ti.com> wrote: > > dp83867 driver only supports sgmii and not all the newer protocols. > Drop the usage of the generic phy_interface_is_sgmii function and just > matchup to the specific mode supported. > > Reported-by: Tom Rini <trini@konsulko.com> > Suggested-by: Marek Vasut <marek.vasut+renesas@mailbox.org> > Suggested-by: Marek Behún <kabel@kernel.org> > Link: https://lore.kernel.org/all/b82ac325-4818-8e72-054b-640268dbf806@mailbox.org/ > Signed-off-by: Nishanth Menon <nm@ti.com> > --- > Changes since v2: > * New patch. > > drivers/net/phy/dp83867.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c > index b861bf7cef36..7111e36aa0d0 100644 > --- a/drivers/net/phy/dp83867.c > +++ b/drivers/net/phy/dp83867.c > @@ -330,7 +330,7 @@ static int dp83867_config(struct phy_device *phydev) > DP83867_RGMIIDCTL, delay); > } > > - if (phy_interface_is_sgmii(phydev)) { > + if (phydev->interface == PHY_INTERFACE_MODE_SGMII) { > if (dp83867->sgmii_ref_clk_en) > phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_SGMIICTL, > DP83867_SGMII_TYPE); > -- > 2.40.0 > Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
On Fri, Apr 14, 2023 at 05:06:43PM -0500, Nishanth Menon wrote: > dp83867 driver only supports sgmii and not all the newer protocols. > Drop the usage of the generic phy_interface_is_sgmii function and just > matchup to the specific mode supported. > > Reported-by: Tom Rini <trini@konsulko.com> > Suggested-by: Marek Vasut <marek.vasut+renesas@mailbox.org> > Suggested-by: Marek Behún <kabel@kernel.org> > Link: https://lore.kernel.org/all/b82ac325-4818-8e72-054b-640268dbf806@mailbox.org/ > Signed-off-by: Nishanth Menon <nm@ti.com> > Reviewed-by: Ramon Fried <rfried.dev@gmail.com> Applied to u-boot/master, thanks!
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index b861bf7cef36..7111e36aa0d0 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -330,7 +330,7 @@ static int dp83867_config(struct phy_device *phydev) DP83867_RGMIIDCTL, delay); } - if (phy_interface_is_sgmii(phydev)) { + if (phydev->interface == PHY_INTERFACE_MODE_SGMII) { if (dp83867->sgmii_ref_clk_en) phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_SGMIICTL, DP83867_SGMII_TYPE);
dp83867 driver only supports sgmii and not all the newer protocols. Drop the usage of the generic phy_interface_is_sgmii function and just matchup to the specific mode supported. Reported-by: Tom Rini <trini@konsulko.com> Suggested-by: Marek Vasut <marek.vasut+renesas@mailbox.org> Suggested-by: Marek Behún <kabel@kernel.org> Link: https://lore.kernel.org/all/b82ac325-4818-8e72-054b-640268dbf806@mailbox.org/ Signed-off-by: Nishanth Menon <nm@ti.com> --- Changes since v2: * New patch. drivers/net/phy/dp83867.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)