| Message ID | 20230413141303.108780-3-macroalpha82@gmail.com |
|---|---|
| State | Accepted |
| Commit | f89167bb74086fddc95290a6171e4dd9953b34c2 |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | Add RK3588 TRNG | expand |
hi Chris, On Thu, 13 Apr 2023 at 19:43, Chris Morgan <macroalpha82@gmail.com> wrote: > > From: Chris Morgan <macromorgan@hotmail.com> > > Add a node for the trng found on RK3588 SoCs. > > Changes in V3: > - Added Reviewed-By tag. > > Changes in V2: > - None Same comment for the changelog lines as in the other patch. Other than that Acked-by: Sughosh Ganu <sughosh.ganu@linaro.org> -sughosh > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > Reviewed-by: Kever Yang <kever.yang@rock-chips.com> > --- > arch/arm/dts/rk3588s-u-boot.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi b/arch/arm/dts/rk3588s-u-boot.dtsi > index f880f4a167..43aeeb4de3 100644 > --- a/arch/arm/dts/rk3588s-u-boot.dtsi > +++ b/arch/arm/dts/rk3588s-u-boot.dtsi > @@ -43,6 +43,12 @@ > reg = <0x07 0x10>; > }; > }; > + > + rng: rng@fe378000 { > + compatible = "rockchip,trngv1"; > + reg = <0x0 0xfe378000 0x0 0x200>; > + status = "disabled"; > + }; > }; > > &xin24m { > -- > 2.34.1 >
On Thu, 13 Apr 2023 at 19:43, Chris Morgan <macroalpha82@gmail.com> wrote: > > From: Chris Morgan <macromorgan@hotmail.com> > > Add a node for the trng found on RK3588 SoCs. > > Changes in V3: > - Added Reviewed-By tag. > > Changes in V2: > - None > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > Reviewed-by: Kever Yang <kever.yang@rock-chips.com> > --- > arch/arm/dts/rk3588s-u-boot.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > Any particular reason why the node is being included in the u-boot.dtsi, instead of the soc specific dtsi, given that this is describing a hardware peripheral. Why can this not be in the rk3588s.dtsi instead? -sughosh > diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi b/arch/arm/dts/rk3588s-u-boot.dtsi > index f880f4a167..43aeeb4de3 100644 > --- a/arch/arm/dts/rk3588s-u-boot.dtsi > +++ b/arch/arm/dts/rk3588s-u-boot.dtsi > @@ -43,6 +43,12 @@ > reg = <0x07 0x10>; > }; > }; > + > + rng: rng@fe378000 { > + compatible = "rockchip,trngv1"; > + reg = <0x0 0xfe378000 0x0 0x200>; > + status = "disabled"; > + }; > }; > > &xin24m { > -- > 2.34.1 >
On Mon, Apr 17, 2023 at 06:13:18PM +0530, Sughosh Ganu wrote: > On Thu, 13 Apr 2023 at 19:43, Chris Morgan <macroalpha82@gmail.com> wrote: > > > > From: Chris Morgan <macromorgan@hotmail.com> > > > > Add a node for the trng found on RK3588 SoCs. > > > > Changes in V3: > > - Added Reviewed-By tag. > > > > Changes in V2: > > - None > > > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > > Reviewed-by: Kever Yang <kever.yang@rock-chips.com> > > --- > > arch/arm/dts/rk3588s-u-boot.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > Any particular reason why the node is being included in the > u-boot.dtsi, instead of the soc specific dtsi, given that this is > describing a hardware peripheral. Why can this not be in the > rk3588s.dtsi instead? There is no driver in mainline Linux yet. As a result I thought it prudent to add this to the U-Boot specific tree rather than the mainline one. Once it does get support in mainline though I can remove it from here and add it there. I probably should change it to "okay" instead of "disabled" though, and just let the user decide by compiling the driver or not if they want to use it in U-Boot. Thank you. > > -sughosh > > > diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi b/arch/arm/dts/rk3588s-u-boot.dtsi > > index f880f4a167..43aeeb4de3 100644 > > --- a/arch/arm/dts/rk3588s-u-boot.dtsi > > +++ b/arch/arm/dts/rk3588s-u-boot.dtsi > > @@ -43,6 +43,12 @@ > > reg = <0x07 0x10>; > > }; > > }; > > + > > + rng: rng@fe378000 { > > + compatible = "rockchip,trngv1"; > > + reg = <0x0 0xfe378000 0x0 0x200>; > > + status = "disabled"; > > + }; > > }; > > > > &xin24m { > > -- > > 2.34.1 > >
On Tue, 18 Apr 2023 at 00:15, Chris Morgan <macromorgan@hotmail.com> wrote: > > On Mon, Apr 17, 2023 at 06:13:18PM +0530, Sughosh Ganu wrote: > > On Thu, 13 Apr 2023 at 19:43, Chris Morgan <macroalpha82@gmail.com> wrote: > > > > > > From: Chris Morgan <macromorgan@hotmail.com> > > > > > > Add a node for the trng found on RK3588 SoCs. > > > > > > Changes in V3: > > > - Added Reviewed-By tag. > > > > > > Changes in V2: > > > - None > > > > > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > > > Reviewed-by: Kever Yang <kever.yang@rock-chips.com> > > > --- > > > arch/arm/dts/rk3588s-u-boot.dtsi | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > > Any particular reason why the node is being included in the > > u-boot.dtsi, instead of the soc specific dtsi, given that this is > > describing a hardware peripheral. Why can this not be in the > > rk3588s.dtsi instead? > > There is no driver in mainline Linux yet. As a result I thought it > prudent to add this to the U-Boot specific tree rather than the > mainline one. Once it does get support in mainline though I can > remove it from here and add it there. Okay. Please work on moving the node to the soc's dtsi once the binding gets upstreamed in linux. I think there are other rockchip soc's too which have rng nodes in the u-boot.dtsi. -sughosh > I probably should change it > to "okay" instead of "disabled" though, and just let the user > decide by compiling the driver or not if they want to use it in > U-Boot. > > Thank you. > > > > > -sughosh > > > > > diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi b/arch/arm/dts/rk3588s-u-boot.dtsi > > > index f880f4a167..43aeeb4de3 100644 > > > --- a/arch/arm/dts/rk3588s-u-boot.dtsi > > > +++ b/arch/arm/dts/rk3588s-u-boot.dtsi > > > @@ -43,6 +43,12 @@ > > > reg = <0x07 0x10>; > > > }; > > > }; > > > + > > > + rng: rng@fe378000 { > > > + compatible = "rockchip,trngv1"; > > > + reg = <0x0 0xfe378000 0x0 0x200>; > > > + status = "disabled"; > > > + }; > > > }; > > > > > > &xin24m { > > > -- > > > 2.34.1 > > >
diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi b/arch/arm/dts/rk3588s-u-boot.dtsi index f880f4a167..43aeeb4de3 100644 --- a/arch/arm/dts/rk3588s-u-boot.dtsi +++ b/arch/arm/dts/rk3588s-u-boot.dtsi @@ -43,6 +43,12 @@ reg = <0x07 0x10>; }; }; + + rng: rng@fe378000 { + compatible = "rockchip,trngv1"; + reg = <0x0 0xfe378000 0x0 0x200>; + status = "disabled"; + }; }; &xin24m {