| Message ID | 20230224181047.2775829-15-troykiskyboundary@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | CONFIG_IS_ENABLED vs IS_ENABLED | expand |
On Fri, 24 Feb 2023 at 11:11, Troy Kisky <troykiskyboundary@gmail.com> wrote: > > When usage_of_is_enabled_check.sh is added, this will show a false > positive for IS_ENABLED(CONFIG_ENV_IS_NOWHERE). > Use IS_ENABLED_NOCHECK to avoid check and error on SPL builds. > > Signed-off-by: Troy Kisky <troykiskyboundary@gmail.com> > --- > > Changes in v2: > - keep #error, but change condition to use IS_ENABLED_NOCHECK > > board/theobroma-systems/puma_rk3399/puma-rk3399.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Fri, Feb 24, 2023 at 10:10:35AM -0800, Troy Kisky wrote: > When usage_of_is_enabled_check.sh is added, this will show a false > positive for IS_ENABLED(CONFIG_ENV_IS_NOWHERE). > Use IS_ENABLED_NOCHECK to avoid check and error on SPL builds. > > Signed-off-by: Troy Kisky <troykiskyboundary@gmail.com> > --- > > Changes in v2: > - keep #error, but change condition to use IS_ENABLED_NOCHECK > > board/theobroma-systems/puma_rk3399/puma-rk3399.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) As I said against v1, the platform needs to select ENV_IS_NOWHERE.
diff --git a/board/theobroma-systems/puma_rk3399/puma-rk3399.c b/board/theobroma-systems/puma_rk3399/puma-rk3399.c index 97f398bd754..d1e3a544974 100644 --- a/board/theobroma-systems/puma_rk3399/puma-rk3399.c +++ b/board/theobroma-systems/puma_rk3399/puma-rk3399.c @@ -136,7 +136,7 @@ int mmc_get_env_dev(void) return CONFIG_SYS_MMC_ENV_DEV; } -#if !IS_ENABLED(CONFIG_ENV_IS_NOWHERE) +#if !IS_ENABLED_NOCHECK(CONFIG_ENV_IS_NOWHERE) #error Please enable CONFIG_ENV_IS_NOWHERE #endif
When usage_of_is_enabled_check.sh is added, this will show a false positive for IS_ENABLED(CONFIG_ENV_IS_NOWHERE). Use IS_ENABLED_NOCHECK to avoid check and error on SPL builds. Signed-off-by: Troy Kisky <troykiskyboundary@gmail.com> --- Changes in v2: - keep #error, but change condition to use IS_ENABLED_NOCHECK board/theobroma-systems/puma_rk3399/puma-rk3399.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)