| Message ID | 20230216033659.3877684-7-trini@konsulko.com |
|---|---|
| State | Accepted |
| Commit | f47c765dbe7b0813d32f797669db771ffa55b9a2 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [01/13] common/Kconfig: Reword text for BOARD_TYPES | expand |
On Wed, 15 Feb 2023 at 20:38, Tom Rini <trini@konsulko.com> wrote: > > In this platform, arch_misc_init doesn't perform any real function. The > call to get_soc_type_rev has no lasting side effects. > > Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > arch/arm/mach-mvebu/alleycat5/soc.c | 9 --------- > configs/mvebu_ac5_rd_defconfig | 1 - > 2 files changed, 10 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On 16/02/23 16:36, Tom Rini wrote: > In this platform, arch_misc_init doesn't perform any real function. The > call to get_soc_type_rev has no lasting side effects. > > Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> > Signed-off-by: Tom Rini <trini@konsulko.com>\ A hangover from the Marvell code I started with. They've replaced it with an empty arch_misc_init() in their newer u-boot code but not selecting CONFIG_ARCH_MISC_INIT is a much better approach. Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > arch/arm/mach-mvebu/alleycat5/soc.c | 9 --------- > configs/mvebu_ac5_rd_defconfig | 1 - > 2 files changed, 10 deletions(-) > > diff --git a/arch/arm/mach-mvebu/alleycat5/soc.c b/arch/arm/mach-mvebu/alleycat5/soc.c > index efbef233a148..dc69f46eedb2 100644 > --- a/arch/arm/mach-mvebu/alleycat5/soc.c > +++ b/arch/arm/mach-mvebu/alleycat5/soc.c > @@ -287,12 +287,3 @@ int mach_cpu_init(void) > > return 0; > } > - > -int arch_misc_init(void) > -{ > - u32 type, rev; > - > - get_soc_type_rev(&type, &rev); > - > - return 0; > -} > diff --git a/configs/mvebu_ac5_rd_defconfig b/configs/mvebu_ac5_rd_defconfig > index a27202eb23e2..4e66791dbda8 100644 > --- a/configs/mvebu_ac5_rd_defconfig > +++ b/configs/mvebu_ac5_rd_defconfig > @@ -22,7 +22,6 @@ CONFIG_SYS_CONSOLE_ENV_OVERWRITE=y > CONFIG_SYS_CONSOLE_INFO_QUIET=y > CONFIG_DISPLAY_BOARDINFO_LATE=y > CONFIG_ARCH_EARLY_INIT_R=y > -CONFIG_ARCH_MISC_INIT=y > CONFIG_CMD_BOOTZ=y > CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS=10 > CONFIG_CMD_MEMTEST=y
On Wed, Feb 15, 2023 at 10:36:53PM -0500, Tom Rini wrote: > In this platform, arch_misc_init doesn't perform any real function. The > call to get_soc_type_rev has no lasting side effects. > > Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> > Signed-off-by: Tom Rini <trini@konsulko.com> > Reviewed-by: Simon Glass <sjg@chromium.org> > Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Applied to u-boot/next, thanks!
diff --git a/arch/arm/mach-mvebu/alleycat5/soc.c b/arch/arm/mach-mvebu/alleycat5/soc.c index efbef233a148..dc69f46eedb2 100644 --- a/arch/arm/mach-mvebu/alleycat5/soc.c +++ b/arch/arm/mach-mvebu/alleycat5/soc.c @@ -287,12 +287,3 @@ int mach_cpu_init(void) return 0; } - -int arch_misc_init(void) -{ - u32 type, rev; - - get_soc_type_rev(&type, &rev); - - return 0; -} diff --git a/configs/mvebu_ac5_rd_defconfig b/configs/mvebu_ac5_rd_defconfig index a27202eb23e2..4e66791dbda8 100644 --- a/configs/mvebu_ac5_rd_defconfig +++ b/configs/mvebu_ac5_rd_defconfig @@ -22,7 +22,6 @@ CONFIG_SYS_CONSOLE_ENV_OVERWRITE=y CONFIG_SYS_CONSOLE_INFO_QUIET=y CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_ARCH_EARLY_INIT_R=y -CONFIG_ARCH_MISC_INIT=y CONFIG_CMD_BOOTZ=y CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS=10 CONFIG_CMD_MEMTEST=y
In this platform, arch_misc_init doesn't perform any real function. The call to get_soc_type_rev has no lasting side effects. Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> Signed-off-by: Tom Rini <trini@konsulko.com> --- arch/arm/mach-mvebu/alleycat5/soc.c | 9 --------- configs/mvebu_ac5_rd_defconfig | 1 - 2 files changed, 10 deletions(-)