diff mbox series

[06/13] mmc: renesas-sdhi: Drop R-Car H3 ES3.0 HS400 calibration table

Message ID 20230126200607.73185-6-marek.vasut+renesas@mailbox.org
State Accepted
Commit 89f9e729bee6756c48a1d0d3b9ca4a703306ab8a
Delegated to: Marek Vasut
Headers show
Series [01/13] mmc: renesas-sdhi: R-Car M3 r1.3 also uses 4 tuning taps | expand

Commit Message

Marek Vasut Jan. 26, 2023, 8:06 p.m. UTC
From: Hai Pham <hai.pham.ud@renesas.com>

It is unnecessary, so clean it up.

Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> # update commit message, mention ES3.0
---
 drivers/mmc/renesas-sdhi.c | 16 ----------------
 1 file changed, 16 deletions(-)

Comments

Jaehoon Chung Jan. 31, 2023, 11:35 p.m. UTC | #1
On 1/27/23 05:06, Marek Vasut wrote:
> From: Hai Pham <hai.pham.ud@renesas.com>
> 
> It is unnecessary, so clean it up.
> 
> Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> # update commit message, mention ES3.0

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
>  drivers/mmc/renesas-sdhi.c | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/drivers/mmc/renesas-sdhi.c b/drivers/mmc/renesas-sdhi.c
> index 95db8aca931..f85ced26ed8 100644
> --- a/drivers/mmc/renesas-sdhi.c
> +++ b/drivers/mmc/renesas-sdhi.c
> @@ -71,13 +71,6 @@
>  
>  #define CALIB_TABLE_MAX	(RENESAS_SDHI_SCC_TMPPORT_CALIB_CODE_MASK + 1)
>  
> -static const u8 r8a7795_calib_table[2][CALIB_TABLE_MAX] = {
> -	{ 0,  0,  0,  0,  0,  1,  1,  2,  3,  4,  5,  5,  6,  6,  7, 11,
> -	 15, 16, 16, 17, 17, 17, 17, 17, 18, 18, 18, 18, 19, 20, 21, 21 },
> -	{ 3,  3,  4,  4,  5,  6,  6,  7,  8,  8,  9,  9, 10, 11, 12, 15,
> -	 16, 16, 17, 17, 17, 17, 17, 18, 18, 18, 18, 19, 20, 21, 22, 22 }
> -};
> -
>  static const u8 r8a7796_rev13_calib_table[2][CALIB_TABLE_MAX] = {
>  	{ 3,  3,  3,  3,  3,  3,  3,  4,  4,  5,  6,  7,  8,  9, 10, 15,
>  	 16, 16, 16, 16, 16, 16, 17, 18, 18, 19, 20, 21, 22, 23, 24, 25 },
> @@ -886,15 +879,6 @@ static void renesas_sdhi_filter_caps(struct udevice *dev)
>  	    (rmobile_get_cpu_type() == RMOBILE_CPU_TYPE_R8A77965))
>  		priv->hs400_bad_tap = BIT(2) | BIT(3) | BIT(6) | BIT(7);
>  
> -	/* H3 ES3.0 can use HS400 with manual adjustment */
> -	if ((rmobile_get_cpu_type() == RMOBILE_CPU_TYPE_R8A7795) &&
> -	    (rmobile_get_cpu_rev_integer() >= 3)) {
> -		priv->adjust_hs400_enable = true;
> -		priv->adjust_hs400_offset = 0;
> -		priv->adjust_hs400_calib_table =
> -			r8a7795_calib_table[!rmobile_is_gen3_mmc0(priv)];
> -	}
> -
>  	/* M3W ES1.x for x>2 can use HS400 with manual adjustment and taps */
>  	if ((rmobile_get_cpu_type() == RMOBILE_CPU_TYPE_R8A7796) &&
>  	    (rmobile_get_cpu_rev_integer() == 1) &&
diff mbox series

Patch

diff --git a/drivers/mmc/renesas-sdhi.c b/drivers/mmc/renesas-sdhi.c
index 95db8aca931..f85ced26ed8 100644
--- a/drivers/mmc/renesas-sdhi.c
+++ b/drivers/mmc/renesas-sdhi.c
@@ -71,13 +71,6 @@ 
 
 #define CALIB_TABLE_MAX	(RENESAS_SDHI_SCC_TMPPORT_CALIB_CODE_MASK + 1)
 
-static const u8 r8a7795_calib_table[2][CALIB_TABLE_MAX] = {
-	{ 0,  0,  0,  0,  0,  1,  1,  2,  3,  4,  5,  5,  6,  6,  7, 11,
-	 15, 16, 16, 17, 17, 17, 17, 17, 18, 18, 18, 18, 19, 20, 21, 21 },
-	{ 3,  3,  4,  4,  5,  6,  6,  7,  8,  8,  9,  9, 10, 11, 12, 15,
-	 16, 16, 17, 17, 17, 17, 17, 18, 18, 18, 18, 19, 20, 21, 22, 22 }
-};
-
 static const u8 r8a7796_rev13_calib_table[2][CALIB_TABLE_MAX] = {
 	{ 3,  3,  3,  3,  3,  3,  3,  4,  4,  5,  6,  7,  8,  9, 10, 15,
 	 16, 16, 16, 16, 16, 16, 17, 18, 18, 19, 20, 21, 22, 23, 24, 25 },
@@ -886,15 +879,6 @@  static void renesas_sdhi_filter_caps(struct udevice *dev)
 	    (rmobile_get_cpu_type() == RMOBILE_CPU_TYPE_R8A77965))
 		priv->hs400_bad_tap = BIT(2) | BIT(3) | BIT(6) | BIT(7);
 
-	/* H3 ES3.0 can use HS400 with manual adjustment */
-	if ((rmobile_get_cpu_type() == RMOBILE_CPU_TYPE_R8A7795) &&
-	    (rmobile_get_cpu_rev_integer() >= 3)) {
-		priv->adjust_hs400_enable = true;
-		priv->adjust_hs400_offset = 0;
-		priv->adjust_hs400_calib_table =
-			r8a7795_calib_table[!rmobile_is_gen3_mmc0(priv)];
-	}
-
 	/* M3W ES1.x for x>2 can use HS400 with manual adjustment and taps */
 	if ((rmobile_get_cpu_type() == RMOBILE_CPU_TYPE_R8A7796) &&
 	    (rmobile_get_cpu_rev_integer() == 1) &&