| Message ID | 20230124105510.17608-1-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | 69a3e0779aab4ca4a2f6280fcbfd85bab5ae4256 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | spl: Drop unwanted return in spl_fit_upload_fpga() | expand |
On Tue, Jan 24, 2023 at 12:56 PM Simon Glass <sjg@chromium.org> wrote: > > This was added by mistake and renders the function useless. Fix it. > > Signed-off-by: Simon Glass <sjg@chromium.org> > Fixes: 33c60a38bb9 ("trace: Use notrace for short") > Reported-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier-oss@weidmueller.com> Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io> > --- > > common/spl/spl_fit.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c > index 9ae3e5e35d4..c51482b3b65 100644 > --- a/common/spl/spl_fit.c > +++ b/common/spl/spl_fit.c > @@ -591,7 +591,6 @@ static int spl_fit_upload_fpga(struct spl_fit_info *ctx, int node, > debug("Ignoring compatible = %s property\n", > compatible); > } > - return 0; > > ret = fpga_load(devnum, (void *)fpga_image->load_addr, > fpga_image->size, BIT_FULL, flags); > -- > 2.39.0.246.g2a6d74b583-goog >
On Tue, Jan 24, 2023 at 03:55:10AM -0700, Simon Glass wrote: > This was added by mistake and renders the function useless. Fix it. > > Signed-off-by: Simon Glass <sjg@chromium.org> > Fixes: 33c60a38bb9 ("trace: Use notrace for short") > Reported-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier-oss@weidmueller.com> > Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io> Applied to u-boot/master, thanks!
diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c index 9ae3e5e35d4..c51482b3b65 100644 --- a/common/spl/spl_fit.c +++ b/common/spl/spl_fit.c @@ -591,7 +591,6 @@ static int spl_fit_upload_fpga(struct spl_fit_info *ctx, int node, debug("Ignoring compatible = %s property\n", compatible); } - return 0; ret = fpga_load(devnum, (void *)fpga_image->load_addr, fpga_image->size, BIT_FULL, flags);
This was added by mistake and renders the function useless. Fix it. Signed-off-by: Simon Glass <sjg@chromium.org> Fixes: 33c60a38bb9 ("trace: Use notrace for short") Reported-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier-oss@weidmueller.com> --- common/spl/spl_fit.c | 1 - 1 file changed, 1 deletion(-)