diff mbox series

[2/4] sunxi: remove bogus mmc_pinmux_setup() prototype

Message ID 20221214002244.31479-3-andre.przywara@arm.com
State Accepted
Commit eeaca6ac27ccfd75956c1ad6ca27d9b9caf62c96
Headers show
Series sunxi: minor cleanups and refactoring | expand

Commit Message

Andre Przywara Dec. 14, 2022, 12:22 a.m. UTC 
Since all callers of mmc_pinmux_setup() are located after the definition
of that function, there is no need for a forward declaration (anymore?).

Remove the prototype along with its #ifdef guards.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 board/sunxi/board.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Samuel Holland Dec. 14, 2022, 5:46 a.m. UTC | #1 
On 12/13/22 18:22, Andre Przywara wrote:
> Since all callers of mmc_pinmux_setup() are located after the definition
> of that function, there is no need for a forward declaration (anymore?).
> 
> Remove the prototype along with its #ifdef guards.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>  board/sunxi/board.c | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Samuel Holland <samuel@sholland.org>
Tested-by: Samuel Holland <samuel@sholland.org>
diff mbox series

Patch

diff --git a/board/sunxi/board.c b/board/sunxi/board.c
index 4d2491b5a86..4fe749feb39 100644
--- a/board/sunxi/board.c
+++ b/board/sunxi/board.c
@@ -184,10 +184,6 @@  enum env_location env_get_location(enum env_operation op, int prio)
 	return ENVL_UNKNOWN;
 }
 
-#ifdef CONFIG_DM_MMC
-static void mmc_pinmux_setup(int sdc);
-#endif
-
 /* add board specific code here */
 int board_init(void)
 {