| Message ID | 20221024112504.1340782-1-heiko.thiery@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ARM: dts: imx8mq-kontron-pitx-imx8m: Remove off-on-delay-us property | expand |
Hi Heiko, On Mon, Oct 24, 2022 at 8:25 AM Heiko Thiery <heiko.thiery@gmail.com> wrote: > > U-Boot is not able to store the environment variables in the SD card. > > Remove the off-on-delay-us property to fix the regression. > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > --- > The same change is done in the linux dts file. I saw your equivalent patch to the Linux devicetree. When I saw it, it was unclear whether it fixed a bug. Reading the commit log of this patch, it becomes clear. I suggest you improve the commit log to the other patch to state that it fixes a real bug. Reviewed-by: Fabio Estevam <festevam@denx.de>
Hi, Am Mo., 24. Okt. 2022 um 13:31 Uhr schrieb Fabio Estevam <festevam@gmail.com>: > > Hi Heiko, > > On Mon, Oct 24, 2022 at 8:25 AM Heiko Thiery <heiko.thiery@gmail.com> wrote: > > > > U-Boot is not able to store the environment variables in the SD card. > > > > Remove the off-on-delay-us property to fix the regression. > > > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > > --- > > The same change is done in the linux dts file. > > I saw your equivalent patch to the Linux devicetree. When I saw it, it > was unclear whether it fixed a bug. > > Reading the commit log of this patch, it becomes clear. > > I suggest you improve the commit log to the other patch to state that > it fixes a real bug. Will do, thanks! > > Reviewed-by: Fabio Estevam <festevam@denx.de>
On 10/24/2022 7:25 PM, Heiko Thiery wrote: > U-Boot is not able to store the environment variables in the SD card. > > Remove the off-on-delay-us property to fix the regression. off-on-delay-us here would cause store env failure? Would you please share more info? Thanks, Peng. > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > --- > The same change is done in the linux dts file. > > arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts b/arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts > index a91c136797..21442e04a6 100644 > --- a/arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts > +++ b/arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts > @@ -51,7 +51,6 @@ > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; > - off-on-delay-us = <20000>; > enable-active-high; > }; > };
Hi Peng, Am Di., 25. Okt. 2022 um 07:18 Uhr schrieb Peng Fan <peng.fan@oss.nxp.com>: > > > > On 10/24/2022 7:25 PM, Heiko Thiery wrote: > > U-Boot is not able to store the environment variables in the SD card. > > > > Remove the off-on-delay-us property to fix the regression. > > off-on-delay-us here would cause store env failure? > Would you please share more info? I saw that the environment could not be loaded/stored since the synchroinzation of the device tree from linux 181d1684cae07f111 (imx8mq: synchronise device tree with linux) and then without doing a bisect I found this commit 5d42ea553534 (ARM: dts: imx8mq-evk: Remove u-boot,off-on-delay-us property). After removing the delay loading/storing worked again.
Hi Heiko On Tue, Oct 25, 2022 at 8:43 AM Heiko Thiery <heiko.thiery@gmail.com> wrote: > > Hi Peng, > > Am Di., 25. Okt. 2022 um 07:18 Uhr schrieb Peng Fan <peng.fan@oss.nxp.com>: > > > > > > > > On 10/24/2022 7:25 PM, Heiko Thiery wrote: > > > U-Boot is not able to store the environment variables in the SD card. > > > > > > Remove the off-on-delay-us property to fix the regression. > > > > off-on-delay-us here would cause store env failure? > > Would you please share more info? > > I saw that the environment could not be loaded/stored since the > synchroinzation of the device tree from linux 181d1684cae07f111 > (imx8mq: synchronise device tree with linux) and then without doing a > bisect I found this commit 5d42ea553534 (ARM: dts: imx8mq-evk: Remove > u-boot,off-on-delay-us property). After removing the delay > loading/storing worked again. > What is not clear apart the environment store if the sdcard is working or not Michael > -- > Heiko > > > > > > > Thanks, > > Peng. > > > > > > > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > > > --- > > > The same change is done in the linux dts file. > > > > > > arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts b/arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts > > > index a91c136797..21442e04a6 100644 > > > --- a/arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts > > > +++ b/arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts > > > @@ -51,7 +51,6 @@ > > > regulator-min-microvolt = <3300000>; > > > regulator-max-microvolt = <3300000>; > > > gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; > > > - off-on-delay-us = <20000>; > > > enable-active-high; > > > }; > > > };
Hi Michael, Am Di., 25. Okt. 2022 um 08:46 Uhr schrieb Michael Nazzareno Trimarchi <michael@amarulasolutions.com>: > > Hi Heiko > > On Tue, Oct 25, 2022 at 8:43 AM Heiko Thiery <heiko.thiery@gmail.com> wrote: > > > > Hi Peng, > > > > Am Di., 25. Okt. 2022 um 07:18 Uhr schrieb Peng Fan <peng.fan@oss.nxp.com>: > > > > > > > > > > > > On 10/24/2022 7:25 PM, Heiko Thiery wrote: > > > > U-Boot is not able to store the environment variables in the SD card. > > > > > > > > Remove the off-on-delay-us property to fix the regression. > > > > > > off-on-delay-us here would cause store env failure? > > > Would you please share more info? > > > > I saw that the environment could not be loaded/stored since the > > synchroinzation of the device tree from linux 181d1684cae07f111 > > (imx8mq: synchronise device tree with linux) and then without doing a > > bisect I found this commit 5d42ea553534 (ARM: dts: imx8mq-evk: Remove > > u-boot,off-on-delay-us property). After removing the delay > > loading/storing worked again. > > > > What is not clear apart the environment store if the sdcard is working or not Ok, Accessing the SD card at all is not working. I only noticed it first because the environment could not be loaded.
diff --git a/arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts b/arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts index a91c136797..21442e04a6 100644 --- a/arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts +++ b/arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts @@ -51,7 +51,6 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; - off-on-delay-us = <20000>; enable-active-high; }; };
U-Boot is not able to store the environment variables in the SD card. Remove the off-on-delay-us property to fix the regression. Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> --- The same change is done in the linux dts file. arch/arm/dts/imx8mq-kontron-pitx-imx8m.dts | 1 - 1 file changed, 1 deletion(-)