| Message ID | 20220908080627.1762034-3-alain.volmat@foss.st.com |
|---|---|
| State | Superseded |
| Delegated to: | Patrick Delaunay |
| Headers | show |
| Series | i2c: stm32: cleanup & stop handling fix | expand |
Hi On 9/8/22 10:06, Alain Volmat wrote: > Functions stm32_i2c_message_start and stm32_i2c_handle_reload > both get a stop boolean indicating if the transfer should end with > a STOP or not. However no specific handling is needed in those > functions hence remove the parameter. > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> > --- > drivers/i2c/stm32f7_i2c.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c > index 78d7156492..0ec67b5c12 100644 > --- a/drivers/i2c/stm32f7_i2c.c > +++ b/drivers/i2c/stm32f7_i2c.c > @@ -282,7 +282,7 @@ static int stm32_i2c_check_device_busy(struct stm32_i2c_priv *i2c_priv) > } > > static void stm32_i2c_message_start(struct stm32_i2c_priv *i2c_priv, > - struct i2c_msg *msg, bool stop) > + struct i2c_msg *msg) > { > struct stm32_i2c_regs *regs = i2c_priv->regs; > u32 cr2 = readl(®s->cr2); > @@ -325,7 +325,7 @@ static void stm32_i2c_message_start(struct stm32_i2c_priv *i2c_priv, > */ > > static void stm32_i2c_handle_reload(struct stm32_i2c_priv *i2c_priv, > - struct i2c_msg *msg, bool stop) > + struct i2c_msg *msg) > { > struct stm32_i2c_regs *regs = i2c_priv->regs; > u32 cr2 = readl(®s->cr2); > @@ -431,7 +431,7 @@ static int stm32_i2c_message_xfer(struct stm32_i2c_priv *i2c_priv, > /* Add errors */ > mask |= STM32_I2C_ISR_ERRORS; > > - stm32_i2c_message_start(i2c_priv, msg, stop); > + stm32_i2c_message_start(i2c_priv, msg); > > while (msg->len) { > /* > @@ -469,7 +469,7 @@ static int stm32_i2c_message_xfer(struct stm32_i2c_priv *i2c_priv, > mask = msg->flags & I2C_M_RD ? STM32_I2C_ISR_RXNE : > STM32_I2C_ISR_TXIS | STM32_I2C_ISR_NACKF; > > - stm32_i2c_handle_reload(i2c_priv, msg, stop); > + stm32_i2c_handle_reload(i2c_priv, msg); > } else if (!bytes_to_rw) { > /* Wait until TC flag is set */ > mask = STM32_I2C_ISR_TC; Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Thanks Patrick
diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c index 78d7156492..0ec67b5c12 100644 --- a/drivers/i2c/stm32f7_i2c.c +++ b/drivers/i2c/stm32f7_i2c.c @@ -282,7 +282,7 @@ static int stm32_i2c_check_device_busy(struct stm32_i2c_priv *i2c_priv) } static void stm32_i2c_message_start(struct stm32_i2c_priv *i2c_priv, - struct i2c_msg *msg, bool stop) + struct i2c_msg *msg) { struct stm32_i2c_regs *regs = i2c_priv->regs; u32 cr2 = readl(®s->cr2); @@ -325,7 +325,7 @@ static void stm32_i2c_message_start(struct stm32_i2c_priv *i2c_priv, */ static void stm32_i2c_handle_reload(struct stm32_i2c_priv *i2c_priv, - struct i2c_msg *msg, bool stop) + struct i2c_msg *msg) { struct stm32_i2c_regs *regs = i2c_priv->regs; u32 cr2 = readl(®s->cr2); @@ -431,7 +431,7 @@ static int stm32_i2c_message_xfer(struct stm32_i2c_priv *i2c_priv, /* Add errors */ mask |= STM32_I2C_ISR_ERRORS; - stm32_i2c_message_start(i2c_priv, msg, stop); + stm32_i2c_message_start(i2c_priv, msg); while (msg->len) { /* @@ -469,7 +469,7 @@ static int stm32_i2c_message_xfer(struct stm32_i2c_priv *i2c_priv, mask = msg->flags & I2C_M_RD ? STM32_I2C_ISR_RXNE : STM32_I2C_ISR_TXIS | STM32_I2C_ISR_NACKF; - stm32_i2c_handle_reload(i2c_priv, msg, stop); + stm32_i2c_handle_reload(i2c_priv, msg); } else if (!bytes_to_rw) { /* Wait until TC flag is set */ mask = STM32_I2C_ISR_TC;
Functions stm32_i2c_message_start and stm32_i2c_handle_reload both get a stop boolean indicating if the transfer should end with a STOP or not. However no specific handling is needed in those functions hence remove the parameter. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> --- drivers/i2c/stm32f7_i2c.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)