| Message ID | 20220611060903.684685-1-heiko.thiery@gmail.com |
|---|---|
| State | Accepted |
| Commit | b11b5afa6a17a2aedf174d4d4ee5d70b04e245c6 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | arm64: dts: imx8mq-kontron-pitx-imx8m-u-boot.dtsi: disable assigned clocks | expand |
On 6/11/22 08:09, Heiko Thiery wrote: > With the move to use DM_CLK the boards uart stops working. The used > properties are not supported by the imx8mq clock driver. Thus > the correct baudrate cannot be selected. Remove this properties here and > the board can start with working uart. Keep it in the main dts because > linux handles these porperties fine. Is this yet another 75f080df46f ("Revert "clk: Detect failure to set defaults"") kind of failure, where the clock uclass returns error code on something? Maybe the clock uclass should rather warn than fail outright, so we won't need these workarounds in DT files ?
Hi Marek, Am Sa., 11. Juni 2022 um 12:15 Uhr schrieb Marek Vasut <marex@denx.de>: > > On 6/11/22 08:09, Heiko Thiery wrote: > > With the move to use DM_CLK the boards uart stops working. The used > > properties are not supported by the imx8mq clock driver. Thus > > the correct baudrate cannot be selected. Remove this properties here and > > the board can start with working uart. Keep it in the main dts because > > linux handles these porperties fine. > > Is this yet another > > 75f080df46f ("Revert "clk: Detect failure to set defaults"") > > kind of failure, where the clock uclass returns error code on something? > > Maybe the clock uclass should rather warn than fail outright, so we > won't need these workarounds in DT files ? I think this is another kind of issue here. I had already tried to solve the problem [1], but had not been able to follow it through to the end. Maybe now is the right time to tackle it again. But due to lack of time i can't say when i will get to it yet. [1] https://patchwork.ozlabs.org/project/uboot/patch/20220317124127.1783768-1-heiko.thiery@gmail.com/
Hi Tom, Am Sa., 11. Juni 2022 um 16:56 Uhr schrieb Heiko Thiery <heiko.thiery@gmail.com>: > > Hi Marek, > > Am Sa., 11. Juni 2022 um 12:15 Uhr schrieb Marek Vasut <marex@denx.de>: > > > > On 6/11/22 08:09, Heiko Thiery wrote: > > > With the move to use DM_CLK the boards uart stops working. The used > > > properties are not supported by the imx8mq clock driver. Thus > > > the correct baudrate cannot be selected. Remove this properties here and > > > the board can start with working uart. Keep it in the main dts because > > > linux handles these porperties fine. > > > > Is this yet another > > > > 75f080df46f ("Revert "clk: Detect failure to set defaults"") > > > > kind of failure, where the clock uclass returns error code on something? > > > > Maybe the clock uclass should rather warn than fail outright, so we > > won't need these workarounds in DT files ? > > I think this is another kind of issue here. I had already tried to > solve the problem [1], but had not been able to follow it through to > the end. > > Maybe now is the right time to tackle it again. But due to lack of > time i can't say when i will get to it yet. > > [1] https://patchwork.ozlabs.org/project/uboot/patch/20220317124127.1783768-1-heiko.thiery@gmail.com/ Is there a chance that this patch can still come in the next RC? Without this change, the board no longer starts correctly. > -- > Heiko
On Tue, Jun 14, 2022 at 06:11:11AM +0200, Heiko Thiery wrote: > Hi Tom, > > Am Sa., 11. Juni 2022 um 16:56 Uhr schrieb Heiko Thiery > <heiko.thiery@gmail.com>: > > > > Hi Marek, > > > > Am Sa., 11. Juni 2022 um 12:15 Uhr schrieb Marek Vasut <marex@denx.de>: > > > > > > On 6/11/22 08:09, Heiko Thiery wrote: > > > > With the move to use DM_CLK the boards uart stops working. The used > > > > properties are not supported by the imx8mq clock driver. Thus > > > > the correct baudrate cannot be selected. Remove this properties here and > > > > the board can start with working uart. Keep it in the main dts because > > > > linux handles these porperties fine. > > > > > > Is this yet another > > > > > > 75f080df46f ("Revert "clk: Detect failure to set defaults"") > > > > > > kind of failure, where the clock uclass returns error code on something? > > > > > > Maybe the clock uclass should rather warn than fail outright, so we > > > won't need these workarounds in DT files ? > > > > I think this is another kind of issue here. I had already tried to > > solve the problem [1], but had not been able to follow it through to > > the end. > > > > Maybe now is the right time to tackle it again. But due to lack of > > time i can't say when i will get to it yet. > > > > [1] https://patchwork.ozlabs.org/project/uboot/patch/20220317124127.1783768-1-heiko.thiery@gmail.com/ > > Is there a chance that this patch can still come in the next RC? > Without this change, the board no longer starts correctly. I've put it in my queue.
On Sat, Jun 11, 2022 at 08:09:04AM +0200, Heiko Thiery wrote: > With the move to use DM_CLK the boards uart stops working. The used > properties are not supported by the imx8mq clock driver. Thus > the correct baudrate cannot be selected. Remove this properties here and > the board can start with working uart. Keep it in the main dts because > linux handles these porperties fine. > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> Applied to u-boot/master, thanks!
diff --git a/arch/arm/dts/imx8mq-kontron-pitx-imx8m-u-boot.dtsi b/arch/arm/dts/imx8mq-kontron-pitx-imx8m-u-boot.dtsi index 6f9c81462e..d361f3f559 100644 --- a/arch/arm/dts/imx8mq-kontron-pitx-imx8m-u-boot.dtsi +++ b/arch/arm/dts/imx8mq-kontron-pitx-imx8m-u-boot.dtsi @@ -10,3 +10,18 @@ sd-uhs-sdr104; sd-uhs-ddr50; }; + +&uart1 { + /delete-property/ assigned-clocks; + /delete-property/ assigned-clock-parents; +}; + +&uart2 { + /delete-property/ assigned-clocks; + /delete-property/ assigned-clock-parents; +}; + +&uart3 { + /delete-property/ assigned-clocks; + /delete-property/ assigned-clock-parents; +};
With the move to use DM_CLK the boards uart stops working. The used properties are not supported by the imx8mq clock driver. Thus the correct baudrate cannot be selected. Remove this properties here and the board can start with working uart. Keep it in the main dts because linux handles these porperties fine. Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> --- .../arm/dts/imx8mq-kontron-pitx-imx8m-u-boot.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+)