| Message ID | 20220530084235.13027-1-pali@kernel.org |
|---|---|
| State | Accepted |
| Commit | 56e3d6ef5dde71065ecdcc6e008372999d09c7d0 |
| Delegated to: | Stefan Roese |
| Headers | show |
| Series | tlv_eeprom: Add missing CRC32 dependency | expand |
Hi Pali, On Mon, May 30 2022, Pali Rohár wrote: > tlv_eeprom uses crc32() function, so add dependency into Kconfig. > > Signed-off-by: Pali Rohár <pali@kernel.org> Reviewed-by: Baruch Siach <baruch@tkos.co.il> Thanks, baruch > --- > cmd/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index 69c1814d24af..d513d808aa3d 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -167,6 +167,7 @@ config CMD_REGINFO > config CMD_TLV_EEPROM > bool "tlv_eeprom" > depends on I2C_EEPROM > + select CRC32 > help > Display and program the system EEPROM data block in ONIE Tlvinfo > format. TLV stands for Type-Length-Value. > @@ -175,6 +176,7 @@ config SPL_CMD_TLV_EEPROM > bool "tlv_eeprom for SPL" > depends on SPL_I2C_EEPROM > select SPL_DRIVERS_MISC > + select SPL_CRC32 > help > Read system EEPROM data block in ONIE Tlvinfo format from SPL.
On 30.05.22 10:42, Pali Rohár wrote: > tlv_eeprom uses crc32() function, so add dependency into Kconfig. > > Signed-off-by: Pali Rohár <pali@kernel.org> Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan > --- > cmd/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index 69c1814d24af..d513d808aa3d 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -167,6 +167,7 @@ config CMD_REGINFO > config CMD_TLV_EEPROM > bool "tlv_eeprom" > depends on I2C_EEPROM > + select CRC32 > help > Display and program the system EEPROM data block in ONIE Tlvinfo > format. TLV stands for Type-Length-Value. > @@ -175,6 +176,7 @@ config SPL_CMD_TLV_EEPROM > bool "tlv_eeprom for SPL" > depends on SPL_I2C_EEPROM > select SPL_DRIVERS_MISC > + select SPL_CRC32 > help > Read system EEPROM data block in ONIE Tlvinfo format from SPL. > Viele Grüße, Stefan Roese
On 30.05.22 10:42, Pali Rohár wrote: > tlv_eeprom uses crc32() function, so add dependency into Kconfig. > > Signed-off-by: Pali Rohár <pali@kernel.org> Applied to u-boot-marvell/master Thanks, Stefan > --- > cmd/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index 69c1814d24af..d513d808aa3d 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -167,6 +167,7 @@ config CMD_REGINFO > config CMD_TLV_EEPROM > bool "tlv_eeprom" > depends on I2C_EEPROM > + select CRC32 > help > Display and program the system EEPROM data block in ONIE Tlvinfo > format. TLV stands for Type-Length-Value. > @@ -175,6 +176,7 @@ config SPL_CMD_TLV_EEPROM > bool "tlv_eeprom for SPL" > depends on SPL_I2C_EEPROM > select SPL_DRIVERS_MISC > + select SPL_CRC32 > help > Read system EEPROM data block in ONIE Tlvinfo format from SPL. > Viele Grüße, Stefan Roese
diff --git a/cmd/Kconfig b/cmd/Kconfig index 69c1814d24af..d513d808aa3d 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -167,6 +167,7 @@ config CMD_REGINFO config CMD_TLV_EEPROM bool "tlv_eeprom" depends on I2C_EEPROM + select CRC32 help Display and program the system EEPROM data block in ONIE Tlvinfo format. TLV stands for Type-Length-Value. @@ -175,6 +176,7 @@ config SPL_CMD_TLV_EEPROM bool "tlv_eeprom for SPL" depends on SPL_I2C_EEPROM select SPL_DRIVERS_MISC + select SPL_CRC32 help Read system EEPROM data block in ONIE Tlvinfo format from SPL.
tlv_eeprom uses crc32() function, so add dependency into Kconfig. Signed-off-by: Pali Rohár <pali@kernel.org> --- cmd/Kconfig | 2 ++ 1 file changed, 2 insertions(+)