| Message ID | 20220503085807.904742-2-rasmus.villemoes@prevas.dk |
|---|---|
| State | Superseded |
| Delegated to: | Jaehoon Chung |
| Headers | show |
| Series | [1/2] pmic: pca9450: add DM_I2C dependencies in Kconfig | expand |
On 5/3/22 17:58, Rasmus Villemoes wrote: > These are the i2c addresses of the chips, but that comes from device > tree. Having that information duplicated here just adds confusion. > > Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > drivers/power/pmic/pca9450.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c > index 2394b196c5..34cee34dba 100644 > --- a/drivers/power/pmic/pca9450.c > +++ b/drivers/power/pmic/pca9450.c > @@ -81,9 +81,9 @@ static struct dm_pmic_ops pca9450_ops = { > }; > > static const struct udevice_id pca9450_ids[] = { > - { .compatible = "nxp,pca9450a", .data = 0x25, }, > - { .compatible = "nxp,pca9450b", .data = 0x25, }, > - { .compatible = "nxp,pca9450c", .data = 0x25, }, > + { .compatible = "nxp,pca9450a" }, > + { .compatible = "nxp,pca9450b" }, > + { .compatible = "nxp,pca9450c" }, > { } > }; >
Dear Rasums, On 5/17/22 08:44, Jaehoon Chung wrote: > On 5/3/22 17:58, Rasmus Villemoes wrote: >> These are the i2c addresses of the chips, but that comes from device >> tree. Having that information duplicated here just adds confusion. >> >> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk> There is a conflict with commit 326337fb005f968911d897867d09d1228b070d84. Could you send the patch again? Sorry for too late. Best Regards, Jaehoon Chung > > > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> > > Best Regards, > Jaehoon Chung > >> --- >> drivers/power/pmic/pca9450.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c >> index 2394b196c5..34cee34dba 100644 >> --- a/drivers/power/pmic/pca9450.c >> +++ b/drivers/power/pmic/pca9450.c >> @@ -81,9 +81,9 @@ static struct dm_pmic_ops pca9450_ops = { >> }; >> >> static const struct udevice_id pca9450_ids[] = { >> - { .compatible = "nxp,pca9450a", .data = 0x25, }, >> - { .compatible = "nxp,pca9450b", .data = 0x25, }, >> - { .compatible = "nxp,pca9450c", .data = 0x25, }, >> + { .compatible = "nxp,pca9450a" }, >> + { .compatible = "nxp,pca9450b" }, >> + { .compatible = "nxp,pca9450c" }, >> { } >> }; >> > >
On 02/06/2022 02.30, Jaehoon Chung wrote: > Dear Rasums, > > On 5/17/22 08:44, Jaehoon Chung wrote: >> On 5/3/22 17:58, Rasmus Villemoes wrote: >>> These are the i2c addresses of the chips, but that comes from device >>> tree. Having that information duplicated here just adds confusion. >>> >>> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk> > > There is a conflict with commit 326337fb005f968911d897867d09d1228b070d84. > Could you send the patch again? Sorry for too late. Oh, but that commit repurposes the .data member - or rather, "purposes", but I don't think that's a real verb. Previously the driver_data wasn't used for anything, but it is now. So my patch should simply be dropped. Rasmus
On 6/2/22 21:30, Rasmus Villemoes wrote: > On 02/06/2022 02.30, Jaehoon Chung wrote: >> Dear Rasums, >> >> On 5/17/22 08:44, Jaehoon Chung wrote: >>> On 5/3/22 17:58, Rasmus Villemoes wrote: >>>> These are the i2c addresses of the chips, but that comes from device >>>> tree. Having that information duplicated here just adds confusion. >>>> >>>> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk> >> >> There is a conflict with commit 326337fb005f968911d897867d09d1228b070d84. >> Could you send the patch again? Sorry for too late. > > Oh, but that commit repurposes the .data member - or rather, "purposes", > but I don't think that's a real verb. Previously the driver_data wasn't > used for anything, but it is now. > > So my patch should simply be dropped. Okay. Thanks! Best Regards, Jaehoon Chung > > Rasmus >
diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c index 2394b196c5..34cee34dba 100644 --- a/drivers/power/pmic/pca9450.c +++ b/drivers/power/pmic/pca9450.c @@ -81,9 +81,9 @@ static struct dm_pmic_ops pca9450_ops = { }; static const struct udevice_id pca9450_ids[] = { - { .compatible = "nxp,pca9450a", .data = 0x25, }, - { .compatible = "nxp,pca9450b", .data = 0x25, }, - { .compatible = "nxp,pca9450c", .data = 0x25, }, + { .compatible = "nxp,pca9450a" }, + { .compatible = "nxp,pca9450b" }, + { .compatible = "nxp,pca9450c" }, { } };
These are the i2c addresses of the chips, but that comes from device tree. Having that information duplicated here just adds confusion. Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk> --- drivers/power/pmic/pca9450.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)