diff mbox series

[v2,5/6] board: amlogic: jethub j100: enable saradc in dts

Message ID 20220422052914.1836694-6-adeep@lexina.in
State Superseded
Delegated to: Neil Armstrong
Headers show
Series meson: add clk and adc support for JetHub D1 (j100) | expand

Commit Message

Viacheslav April 22, 2022, 5:29 a.m. UTC
Prepare to use ADC channel 1 to check the hardware revision of the board.

Signed-off-by: Vyacheslav Bocharov <adeep@lexina.in>
---
 arch/arm/dts/meson-axg-jethome-jethub-j100.dts | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Neil Armstrong April 22, 2022, 1:26 p.m. UTC | #1
On 22/04/2022 07:29, Vyacheslav Bocharov wrote:
> Prepare to use ADC channel 1 to check the hardware revision of the board.
> 
> Signed-off-by: Vyacheslav Bocharov <adeep@lexina.in>
> ---
>   arch/arm/dts/meson-axg-jethome-jethub-j100.dts | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/dts/meson-axg-jethome-jethub-j100.dts b/arch/arm/dts/meson-axg-jethome-jethub-j100.dts
> index 5783732dc6..00a0b268af 100644
> --- a/arch/arm/dts/meson-axg-jethome-jethub-j100.dts
> +++ b/arch/arm/dts/meson-axg-jethome-jethub-j100.dts
> @@ -359,3 +359,8 @@
>   &cpu3 {
>   	#cooling-cells = <2>;
>   };
> +
> +&saradc {
> +	status = "okay";
> +	vref-supply = <&vddio_ao18>;
> +};

Please move this in a -u-boot.dtsi file to keep the main DT in sync with Linux.

Neil
Viacheslav April 23, 2022, 7:06 a.m. UTC | #2
22.04.2022 16:26, Neil Armstrong wrote:
> On 22/04/2022 07:29, Vyacheslav Bocharov wrote:
>> Prepare to use ADC channel 1 to check the hardware revision of the board.
>>
>> Signed-off-by: Vyacheslav Bocharov <adeep@lexina.in>
>> ---
>>   arch/arm/dts/meson-axg-jethome-jethub-j100.dts | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/dts/meson-axg-jethome-jethub-j100.dts 
>> b/arch/arm/dts/meson-axg-jethome-jethub-j100.dts
>> index 5783732dc6..00a0b268af 100644
>> --- a/arch/arm/dts/meson-axg-jethome-jethub-j100.dts
>> +++ b/arch/arm/dts/meson-axg-jethome-jethub-j100.dts
>> @@ -359,3 +359,8 @@
>>   &cpu3 {
>>       #cooling-cells = <2>;
>>   };
>> +
>> +&saradc {
>> +    status = "okay";
>> +    vref-supply = <&vddio_ao18>;
>> +};
> 
> Please move this in a -u-boot.dtsi file to keep the main DT in sync with 
> Linux.

Thanks. Anyway, I will submit patch to the kernel later.

> Neil
diff mbox series

Patch

diff --git a/arch/arm/dts/meson-axg-jethome-jethub-j100.dts b/arch/arm/dts/meson-axg-jethome-jethub-j100.dts
index 5783732dc6..00a0b268af 100644
--- a/arch/arm/dts/meson-axg-jethome-jethub-j100.dts
+++ b/arch/arm/dts/meson-axg-jethome-jethub-j100.dts
@@ -359,3 +359,8 @@ 
 &cpu3 {
 	#cooling-cells = <2>;
 };
+
+&saradc {
+	status = "okay";
+	vref-supply = <&vddio_ao18>;
+};