| Message ID | 20220415114643.1.Id540e65885e62d3a51328b7f4205a137cd249537@changeid |
|---|---|
| State | Accepted |
| Commit | 1494e3758634a32a79484099ee9a86ff5e7d737a |
| Delegated to: | Patrice Chotard |
| Headers | show |
| Series | board: st: common: fix the error messages in stboard command | expand |
Hi Patrick On 4/15/22 11:46, Patrick Delaunay wrote: > Add missing \n at the end of the error trace > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > board/st/common/cmd_stboard.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/board/st/common/cmd_stboard.c b/board/st/common/cmd_stboard.c > index c1ecd643b0..e12669b862 100644 > --- a/board/st/common/cmd_stboard.c > +++ b/board/st/common/cmd_stboard.c > @@ -92,14 +92,14 @@ static int do_stboard(struct cmd_tbl *cmdtp, int flag, int argc, > &otp, sizeof(otp)); > > if (ret != sizeof(otp)) { > - puts("OTP read error"); > + puts("OTP read error\n"); > return CMD_RET_FAILURE; > } > > ret = misc_read(dev, STM32_BSEC_LOCK(BSEC_OTP_BOARD), > &lock, sizeof(lock)); > if (ret != sizeof(lock)) { > - puts("LOCK read error"); > + puts("LOCK read error\n"); > return CMD_RET_FAILURE; > } > Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> Thanks Patrice
On 4/15/22 11:46, Patrick Delaunay wrote: > Add missing \n at the end of the error trace > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > board/st/common/cmd_stboard.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/board/st/common/cmd_stboard.c b/board/st/common/cmd_stboard.c > index c1ecd643b0..e12669b862 100644 > --- a/board/st/common/cmd_stboard.c > +++ b/board/st/common/cmd_stboard.c > @@ -92,14 +92,14 @@ static int do_stboard(struct cmd_tbl *cmdtp, int flag, int argc, > &otp, sizeof(otp)); > > if (ret != sizeof(otp)) { > - puts("OTP read error"); > + puts("OTP read error\n"); > return CMD_RET_FAILURE; > } > > ret = misc_read(dev, STM32_BSEC_LOCK(BSEC_OTP_BOARD), > &lock, sizeof(lock)); > if (ret != sizeof(lock)) { > - puts("LOCK read error"); > + puts("LOCK read error\n"); > return CMD_RET_FAILURE; > } > Applied to u-boot-stm32 Thanks Patrice
diff --git a/board/st/common/cmd_stboard.c b/board/st/common/cmd_stboard.c index c1ecd643b0..e12669b862 100644 --- a/board/st/common/cmd_stboard.c +++ b/board/st/common/cmd_stboard.c @@ -92,14 +92,14 @@ static int do_stboard(struct cmd_tbl *cmdtp, int flag, int argc, &otp, sizeof(otp)); if (ret != sizeof(otp)) { - puts("OTP read error"); + puts("OTP read error\n"); return CMD_RET_FAILURE; } ret = misc_read(dev, STM32_BSEC_LOCK(BSEC_OTP_BOARD), &lock, sizeof(lock)); if (ret != sizeof(lock)) { - puts("LOCK read error"); + puts("LOCK read error\n"); return CMD_RET_FAILURE; }
Add missing \n at the end of the error trace Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> --- board/st/common/cmd_stboard.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)