diff mbox series

[v2] Add ethernet0 alias in Nanopi NEO's device tree

Message ID 20220326120910.56376-1-baltazar.radics@gmail.com
State Accepted
Commit fbc8acf644ceb41e92d67558c7bb86d730fb8135
Delegated to: Andre Przywara
Headers show
Series [v2] Add ethernet0 alias in Nanopi NEO's device tree | expand

Commit Message

Baltazár Radics March 26, 2022, 12:09 p.m. UTC
This is required to enable automatic MAC address generation.

Signed-off-by: Baltazár Radics <baltazar.radics@gmail.com>
---
 arch/arm/dts/sun8i-h3-nanopi-neo.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Andre Przywara April 3, 2022, 11:32 p.m. UTC | #1
On Sat, 26 Mar 2022 13:09:10 +0100
Baltazár Radics <baltazar.radics@gmail.com> wrote:

Hi Baltazár,

> This is required to enable automatic MAC address generation.

For the records, this should rather be marked as a sync from the Linux
tree, where this was conveniently merged just recently.

In the long run we should see if we can avoid those ethernet aliases,
since their only purpose seems to be to trigger U-Boot's MAC
generation, and I wonder if there is a simpler way. Using U-Boot's DM
interface to enumerate Ethernet devices comes to mind, for instance.
This would avoid the churn of funnelling those trivial DT changes
through Linux first.

I will apply this and push it for the merge window, after adding the
Linux tag.

Thanks!
Andre



> Signed-off-by: Baltazár Radics <baltazar.radics@gmail.com>
> ---
>  arch/arm/dts/sun8i-h3-nanopi-neo.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/dts/sun8i-h3-nanopi-neo.dts b/arch/arm/dts/sun8i-h3-nanopi-neo.dts
> index 9f33f6fae..df71fab3c 100644
> --- a/arch/arm/dts/sun8i-h3-nanopi-neo.dts
> +++ b/arch/arm/dts/sun8i-h3-nanopi-neo.dts
> @@ -45,6 +45,10 @@
>  / {
>  	model = "FriendlyARM NanoPi NEO";
>  	compatible = "friendlyarm,nanopi-neo", "allwinner,sun8i-h3";
> +
> +	aliases {
> +		ethernet0 = &emac;
> +	};
>  };
>  
>  &ehci0 {
diff mbox series

Patch

diff --git a/arch/arm/dts/sun8i-h3-nanopi-neo.dts b/arch/arm/dts/sun8i-h3-nanopi-neo.dts
index 9f33f6fae..df71fab3c 100644
--- a/arch/arm/dts/sun8i-h3-nanopi-neo.dts
+++ b/arch/arm/dts/sun8i-h3-nanopi-neo.dts
@@ -45,6 +45,10 @@ 
 / {
 	model = "FriendlyARM NanoPi NEO";
 	compatible = "friendlyarm,nanopi-neo", "allwinner,sun8i-h3";
+
+	aliases {
+		ethernet0 = &emac;
+	};
 };
 
 &ehci0 {