| Message ID | 20220323180342.1296178-1-ascull@google.com |
|---|---|
| State | Superseded |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | sandbox: sdl: Add stub sandbox_sdl_remove_display() | expand |
Hi Andrew, On Wed, 23 Mar 2022 at 12:06, Andrew Scull <ascull@google.com> wrote: > > > +static int sandbox_sdl_remove_display(void) > > Forgot the inline :/ should I resend or can it be added when applying? Best to resend I think. With that you can add: Reviewed-by: Simon Glass <sjg@chromium.org> > > > +{ > > + return -ENODEV; > > +} > > + > > static inline int sandbox_sdl_sync(void *lcd_base) > > { > > return -ENODEV; Regards, Simon
diff --git a/arch/sandbox/include/asm/sdl.h b/arch/sandbox/include/asm/sdl.h index e271a849af..821b0c6a0e 100644 --- a/arch/sandbox/include/asm/sdl.h +++ b/arch/sandbox/include/asm/sdl.h @@ -94,6 +94,11 @@ static inline int sandbox_sdl_init_display(int width, int height, int log2_bpp, return -ENODEV; } +static int sandbox_sdl_remove_display(void) +{ + return -ENODEV; +} + static inline int sandbox_sdl_sync(void *lcd_base) { return -ENODEV;
Building the sandbox with NO_SDL=1 resulted in an undefined reference to 'sandbox_sdl_remove_display'. Resolve this by adding a stub implementation to match the stubs to the other similar functions. Signed-off-by: Andrew Scull <ascull@google.com> Cc: Simon Glass <sjg@chromium.org> Cc: Anatolij Gustschin <agust@denx.de> --- arch/sandbox/include/asm/sdl.h | 5 +++++ 1 file changed, 5 insertions(+)