[u-boot-net,06/14] net: phy: fix parsing wrong property

Message ID	20220317124958.27921-7-kabel@kernel.org
State	Superseded
Delegated to:	Ramon Fried
Headers	show Return-Path: <u-boot-bounces@lists.denx.de> From: =?utf-8?q?Marek_Beh=C3=BAn?= <kabel@kernel.org> To: Joe Hershberger <joe.hershberger@ni.com>, Ramon Fried <rfried.dev@gmail.com> Cc: u-boot@lists.denx.de, =?utf-8?q?Marek_Beh=C3=BAn?= <marek.behun@nic.cz>, Bin Meng <bmeng.cn@gmail.com>, Michal Simek <michal.simek@xilinx.com>, Priyanka Jain <priyanka.jain@nxp.com>, "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@oss.nxp.com>, Vladimir Oltean <vladimir.oltean@nxp.com> Subject: [PATCH u-boot-net 06/14] net: phy: fix parsing wrong property Date: Thu, 17 Mar 2022 13:49:50 +0100 Message-Id: <20220317124958.27921-7-kabel@kernel.org> In-Reply-To: <20220317124958.27921-1-kabel@kernel.org> References: <20220317124958.27921-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	u-boot-net refactors, fixes, cleanups \| expand [u-boot-net,00/14] u-boot-net refactors, fixes, cleanups [u-boot-net,01/14] net: mdio-uclass: fix type for phy_mode_str and phy_handle_str [u-boot-net,02/14] net: mdio-uclass: use ARRAY_SIZE() [u-boot-net,03/14] net: introduce helpers to get PHY ofnode from MAC [u-boot-net,04/14] net: mdio-uclass: add wrappers for read/write/reset operations [u-boot-net,05/14] treewide: use dm_mdio_read/write/reset() wrappers [u-boot-net,06/14] net: phy: fix parsing wrong property [u-boot-net,07/14] net: introduce helpers to get PHY interface mode from a device/ofnode [u-boot-net,08/14] treewide: Rename PHY_INTERFACE_MODE_COUNT to PHY_INTERFACE_MODE_MAX [u-boot-net,09/14] treewide: Rename PHY_INTERFACE_MODE_NONE to PHY_INTERFACE_MODE_NA [u-boot-net,10/14] phy: Move PHY_INTERFACE_MODE_NA to the beginning of the enum definition [u-boot-net,11/14] net: phy: xilinx: Check interface type in ->config(), not ->probe() [u-boot-net,12/14] net: phy: use ->is_c45 instead of is_10g_interface() [u-boot-net,13/14] bcmgenet, sun8i_emac: Don't connect PHY two times [u-boot-net,14/14] net: phy: don't require PHY interface mode during PHY creation

Message ID

20220317124958.27921-7-kabel@kernel.org

State

Superseded

Delegated to:

Ramon Fried

Headers

From: =?utf-8?q?Marek_Beh=C3=BAn?= <kabel@kernel.org>
To: Joe Hershberger <joe.hershberger@ni.com>,
 Ramon Fried <rfried.dev@gmail.com>
Cc: u-boot@lists.denx.de, =?utf-8?q?Marek_Beh=C3=BAn?= <marek.behun@nic.cz>,
 Bin Meng <bmeng.cn@gmail.com>, Michal Simek <michal.simek@xilinx.com>,
 Priyanka Jain <priyanka.jain@nxp.com>,
 "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@oss.nxp.com>,
 Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: [PATCH u-boot-net 06/14] net: phy: fix parsing wrong property
Date: Thu, 17 Mar 2022 13:49:50 +0100
Message-Id: <20220317124958.27921-7-kabel@kernel.org>
In-Reply-To: <20220317124958.27921-1-kabel@kernel.org>
References: <20220317124958.27921-1-kabel@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

u-boot-net refactors, fixes, cleanups | expand

From: Marek Behún <marek.behun@nic.cz> The "phy-interface-type" property should be "phy-connection-type". Signed-off-by: Marek Behún <marek.behun@nic.cz> --- drivers/net/phy/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ramon Fried March 18, 2022, 8:05 a.m. UTC | #1

On Thu, Mar 17, 2022 at 2:50 PM Marek Behún <kabel@kernel.org> wrote:
>
> From: Marek Behún <marek.behun@nic.cz>
>
> The "phy-interface-type" property should be "phy-connection-type".
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> ---
>  drivers/net/phy/phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index c9fc20855b..fe6dbdaee4 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -989,7 +989,7 @@ struct phy_device *fixed_phy_create(ofnode node)
>
>         if_str = ofnode_read_string(node, "phy-mode");
>         if (!if_str) {
> -               if_str = ofnode_read_string(node, "phy-interface-type");
> +               if_str = ofnode_read_string(node, "phy-connection-type");
>         }
>         if (if_str) {
>                 interface = phy_get_interface_by_name(if_str);
> --
> 2.34.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index c9fc20855b..fe6dbdaee4 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -989,7 +989,7 @@  struct phy_device *fixed_phy_create(ofnode node)
 
 	if_str = ofnode_read_string(node, "phy-mode");
 	if (!if_str) {
-		if_str = ofnode_read_string(node, "phy-interface-type");
+		if_str = ofnode_read_string(node, "phy-connection-type");
 	}
 	if (if_str) {
 		interface = phy_get_interface_by_name(if_str);

[u-boot-net,06/14] net: phy: fix parsing wrong property

Commit Message

Comments

Patch