| Message ID | 20220311191005.364540-4-sjg@chromium.org |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Reduce size of a few boards | expand |
On Fri, Mar 11, 2022 at 12:10:03PM -0700, Simon Glass wrote: > This board is too close to the limit to enable this feature. Drop it. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > configs/rcar3_salvator-x_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configs/rcar3_salvator-x_defconfig b/configs/rcar3_salvator-x_defconfig > index 5fb27d257af..402d56a1321 100644 > --- a/configs/rcar3_salvator-x_defconfig > +++ b/configs/rcar3_salvator-x_defconfig > @@ -102,4 +102,4 @@ CONFIG_USB_EHCI_HCD=y > CONFIG_USB_EHCI_GENERIC=y > CONFIG_USB_STORAGE=y > CONFIG_OF_LIBFDT_OVERLAY=y > -# CONFIG_EFI_UNICODE_CAPITALIZATION is not set > +# CONFIG_EFI_LOADER is not set How close to the limit, but also how interested are the maintainers in having UEFI boot? This is likely another place where run-time checking LTO is advised, but is likely fine as rzg2_beacon already enables it.
Hi Tom, On Fri, 11 Mar 2022 at 13:21, Tom Rini <trini@konsulko.com> wrote: > > On Fri, Mar 11, 2022 at 12:10:03PM -0700, Simon Glass wrote: > > > This board is too close to the limit to enable this feature. Drop it. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > configs/rcar3_salvator-x_defconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configs/rcar3_salvator-x_defconfig b/configs/rcar3_salvator-x_defconfig > > index 5fb27d257af..402d56a1321 100644 > > --- a/configs/rcar3_salvator-x_defconfig > > +++ b/configs/rcar3_salvator-x_defconfig > > @@ -102,4 +102,4 @@ CONFIG_USB_EHCI_HCD=y > > CONFIG_USB_EHCI_GENERIC=y > > CONFIG_USB_STORAGE=y > > CONFIG_OF_LIBFDT_OVERLAY=y > > -# CONFIG_EFI_UNICODE_CAPITALIZATION is not set > > +# CONFIG_EFI_LOADER is not set > > How close to the limit, but also how interested are the maintainers in > having UEFI boot? This is likely another place where run-time checking > LTO is advised, but is likely fine as rzg2_beacon already enables it. About 2.5KB: u-boot.img exceeds file size limit: limit: 0x100000 bytes actual: 0x1009b5 bytes excess: 0x9b5 bytes The board is pretty big - looks like >100KB for the pinmux stuff. Regards, Simon
On Fri, Mar 11, 2022 at 07:24:42PM -0700, Simon Glass wrote: > Hi Tom, > > On Fri, 11 Mar 2022 at 13:21, Tom Rini <trini@konsulko.com> wrote: > > > > On Fri, Mar 11, 2022 at 12:10:03PM -0700, Simon Glass wrote: > > > > > This board is too close to the limit to enable this feature. Drop it. > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > --- > > > > > > configs/rcar3_salvator-x_defconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/configs/rcar3_salvator-x_defconfig b/configs/rcar3_salvator-x_defconfig > > > index 5fb27d257af..402d56a1321 100644 > > > --- a/configs/rcar3_salvator-x_defconfig > > > +++ b/configs/rcar3_salvator-x_defconfig > > > @@ -102,4 +102,4 @@ CONFIG_USB_EHCI_HCD=y > > > CONFIG_USB_EHCI_GENERIC=y > > > CONFIG_USB_STORAGE=y > > > CONFIG_OF_LIBFDT_OVERLAY=y > > > -# CONFIG_EFI_UNICODE_CAPITALIZATION is not set > > > +# CONFIG_EFI_LOADER is not set > > > > How close to the limit, but also how interested are the maintainers in > > having UEFI boot? This is likely another place where run-time checking > > LTO is advised, but is likely fine as rzg2_beacon already enables it. > > About 2.5KB: > > u-boot.img exceeds file size limit: > limit: 0x100000 bytes > actual: 0x1009b5 bytes > excess: 0x9b5 bytes > > The board is pretty big - looks like >100KB for the pinmux stuff. Well, being an arm64 board, it probably wants to stay using standard boot methods, so enable LTO rather than disable functionality is likely the first path to take, but I'll let the board maintainers chime in.
Hi Tom, On Mon, 14 Mar 2022 at 06:54, Tom Rini <trini@konsulko.com> wrote: > > On Fri, Mar 11, 2022 at 07:24:42PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 11 Mar 2022 at 13:21, Tom Rini <trini@konsulko.com> wrote: > > > > > > On Fri, Mar 11, 2022 at 12:10:03PM -0700, Simon Glass wrote: > > > > > > > This board is too close to the limit to enable this feature. Drop it. > > > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > > --- > > > > > > > > configs/rcar3_salvator-x_defconfig | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/configs/rcar3_salvator-x_defconfig b/configs/rcar3_salvator-x_defconfig > > > > index 5fb27d257af..402d56a1321 100644 > > > > --- a/configs/rcar3_salvator-x_defconfig > > > > +++ b/configs/rcar3_salvator-x_defconfig > > > > @@ -102,4 +102,4 @@ CONFIG_USB_EHCI_HCD=y > > > > CONFIG_USB_EHCI_GENERIC=y > > > > CONFIG_USB_STORAGE=y > > > > CONFIG_OF_LIBFDT_OVERLAY=y > > > > -# CONFIG_EFI_UNICODE_CAPITALIZATION is not set > > > > +# CONFIG_EFI_LOADER is not set > > > > > > How close to the limit, but also how interested are the maintainers in > > > having UEFI boot? This is likely another place where run-time checking > > > LTO is advised, but is likely fine as rzg2_beacon already enables it. > > > > About 2.5KB: > > > > u-boot.img exceeds file size limit: > > limit: 0x100000 bytes > > actual: 0x1009b5 bytes > > excess: 0x9b5 bytes > > > > The board is pretty big - looks like >100KB for the pinmux stuff. > > Well, being an arm64 board, it probably wants to stay using standard > boot methods, so enable LTO rather than disable functionality is likely > the first path to take, but I'll let the board maintainers chime in. OK I'll wait for the chime. Regards, Simon
diff --git a/configs/rcar3_salvator-x_defconfig b/configs/rcar3_salvator-x_defconfig index 5fb27d257af..402d56a1321 100644 --- a/configs/rcar3_salvator-x_defconfig +++ b/configs/rcar3_salvator-x_defconfig @@ -102,4 +102,4 @@ CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_GENERIC=y CONFIG_USB_STORAGE=y CONFIG_OF_LIBFDT_OVERLAY=y -# CONFIG_EFI_UNICODE_CAPITALIZATION is not set +# CONFIG_EFI_LOADER is not set
This board is too close to the limit to enable this feature. Drop it. Signed-off-by: Simon Glass <sjg@chromium.org> --- configs/rcar3_salvator-x_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)