| Message ID | 20220301005323.1786382-1-judge.packham@gmail.com |
|---|---|
| State | Accepted |
| Commit | 0a6f0297c677946907b7ba34d34995fe03055aad |
| Delegated to: | Stefan Roese |
| Headers | show |
| Series | ARM: mvebu: x530: clearfog: Add ODT configuration | expand |
Hi Chris, On Tue, Mar 01 2022, Chris Packham wrote: > Commit 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT > configuration") added the odt_config member to struct > mv_ddr_topology_map ahead of the clk_enable and ck_delay members. This > means that any boards that configured either of clk_enable or ck_delay > needed to have their board topology updated. This affects the x530 and > clearfog boards. Other A38x boards don't touch any of the trailing > members of mv_ddr_topology_map so don't need updating. > > Fixes: 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration") > Signed-off-by: Chris Packham <judge.packham@gmail.com> Acked-by: Baruch Siach <baruch@tkos.co.il> Thanks, baruch > --- > > board/alliedtelesis/x530/x530.c | 1 + > board/solidrun/clearfog/clearfog.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/board/alliedtelesis/x530/x530.c b/board/alliedtelesis/x530/x530.c > index 8b31045a0743..c0ec2afa3011 100644 > --- a/board/alliedtelesis/x530/x530.c > +++ b/board/alliedtelesis/x530/x530.c > @@ -73,6 +73,7 @@ static struct mv_ddr_topology_map board_topology_map = { > {0}, /* timing parameters */ > { {0} }, /* electrical configuration */ > {0}, /* electrical parameters */ > + 0, /* ODT configuration */ > 0, /* Clock enable mask */ > 160 /* Clock delay */ > }; > diff --git a/board/solidrun/clearfog/clearfog.c b/board/solidrun/clearfog/clearfog.c > index c920cf8d6b50..03adb591d826 100644 > --- a/board/solidrun/clearfog/clearfog.c > +++ b/board/solidrun/clearfog/clearfog.c > @@ -147,6 +147,7 @@ static struct mv_ddr_topology_map board_topology_map = { > {0}, /* timing parameters */ > { {0} }, /* electrical configuration */ > {0,}, /* electrical parameters */ > + 0, /* ODT configuration */ > 0x3, /* clock enable mask */ > };
On 3/1/22 01:53, Chris Packham wrote: > Commit 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT > configuration") added the odt_config member to struct > mv_ddr_topology_map ahead of the clk_enable and ck_delay members. This > means that any boards that configured either of clk_enable or ck_delay > needed to have their board topology updated. This affects the x530 and > clearfog boards. Other A38x boards don't touch any of the trailing > members of mv_ddr_topology_map so don't need updating. > > Fixes: 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration") > Signed-off-by: Chris Packham <judge.packham@gmail.com> Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan > --- > > board/alliedtelesis/x530/x530.c | 1 + > board/solidrun/clearfog/clearfog.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/board/alliedtelesis/x530/x530.c b/board/alliedtelesis/x530/x530.c > index 8b31045a0743..c0ec2afa3011 100644 > --- a/board/alliedtelesis/x530/x530.c > +++ b/board/alliedtelesis/x530/x530.c > @@ -73,6 +73,7 @@ static struct mv_ddr_topology_map board_topology_map = { > {0}, /* timing parameters */ > { {0} }, /* electrical configuration */ > {0}, /* electrical parameters */ > + 0, /* ODT configuration */ > 0, /* Clock enable mask */ > 160 /* Clock delay */ > }; > diff --git a/board/solidrun/clearfog/clearfog.c b/board/solidrun/clearfog/clearfog.c > index c920cf8d6b50..03adb591d826 100644 > --- a/board/solidrun/clearfog/clearfog.c > +++ b/board/solidrun/clearfog/clearfog.c > @@ -147,6 +147,7 @@ static struct mv_ddr_topology_map board_topology_map = { > {0}, /* timing parameters */ > { {0} }, /* electrical configuration */ > {0,}, /* electrical parameters */ > + 0, /* ODT configuration */ > 0x3, /* clock enable mask */ > }; > Viele Grüße, Stefan Roese
On 3/1/22 01:53, Chris Packham wrote: > Commit 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT > configuration") added the odt_config member to struct > mv_ddr_topology_map ahead of the clk_enable and ck_delay members. This > means that any boards that configured either of clk_enable or ck_delay > needed to have their board topology updated. This affects the x530 and > clearfog boards. Other A38x boards don't touch any of the trailing > members of mv_ddr_topology_map so don't need updating. > > Fixes: 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration") > Signed-off-by: Chris Packham <judge.packham@gmail.com> Applied to u-boot-marvell/master Thanks, Stefan > --- > > board/alliedtelesis/x530/x530.c | 1 + > board/solidrun/clearfog/clearfog.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/board/alliedtelesis/x530/x530.c b/board/alliedtelesis/x530/x530.c > index 8b31045a0743..c0ec2afa3011 100644 > --- a/board/alliedtelesis/x530/x530.c > +++ b/board/alliedtelesis/x530/x530.c > @@ -73,6 +73,7 @@ static struct mv_ddr_topology_map board_topology_map = { > {0}, /* timing parameters */ > { {0} }, /* electrical configuration */ > {0}, /* electrical parameters */ > + 0, /* ODT configuration */ > 0, /* Clock enable mask */ > 160 /* Clock delay */ > }; > diff --git a/board/solidrun/clearfog/clearfog.c b/board/solidrun/clearfog/clearfog.c > index c920cf8d6b50..03adb591d826 100644 > --- a/board/solidrun/clearfog/clearfog.c > +++ b/board/solidrun/clearfog/clearfog.c > @@ -147,6 +147,7 @@ static struct mv_ddr_topology_map board_topology_map = { > {0}, /* timing parameters */ > { {0} }, /* electrical configuration */ > {0,}, /* electrical parameters */ > + 0, /* ODT configuration */ > 0x3, /* clock enable mask */ > }; > Viele Grüße, Stefan Roese
diff --git a/board/alliedtelesis/x530/x530.c b/board/alliedtelesis/x530/x530.c index 8b31045a0743..c0ec2afa3011 100644 --- a/board/alliedtelesis/x530/x530.c +++ b/board/alliedtelesis/x530/x530.c @@ -73,6 +73,7 @@ static struct mv_ddr_topology_map board_topology_map = { {0}, /* timing parameters */ { {0} }, /* electrical configuration */ {0}, /* electrical parameters */ + 0, /* ODT configuration */ 0, /* Clock enable mask */ 160 /* Clock delay */ }; diff --git a/board/solidrun/clearfog/clearfog.c b/board/solidrun/clearfog/clearfog.c index c920cf8d6b50..03adb591d826 100644 --- a/board/solidrun/clearfog/clearfog.c +++ b/board/solidrun/clearfog/clearfog.c @@ -147,6 +147,7 @@ static struct mv_ddr_topology_map board_topology_map = { {0}, /* timing parameters */ { {0} }, /* electrical configuration */ {0,}, /* electrical parameters */ + 0, /* ODT configuration */ 0x3, /* clock enable mask */ };
Commit 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration") added the odt_config member to struct mv_ddr_topology_map ahead of the clk_enable and ck_delay members. This means that any boards that configured either of clk_enable or ck_delay needed to have their board topology updated. This affects the x530 and clearfog boards. Other A38x boards don't touch any of the trailing members of mv_ddr_topology_map so don't need updating. Fixes: 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration") Signed-off-by: Chris Packham <judge.packham@gmail.com> --- board/alliedtelesis/x530/x530.c | 1 + board/solidrun/clearfog/clearfog.c | 1 + 2 files changed, 2 insertions(+)