| Message ID | 20220227141800.37166-1-agraf@csgraf.de |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | qfw: Do not include tables.h on arm | expand |
Hi Alex, On Sun, 27 Feb 2022 at 07:18, Alexander Graf <agraf@csgraf.de> wrote: > > asm/tables.h does not exist on ARM and I did not need it to make the > code compile successfully. Let's not include it there. > > Signed-off-by: Alexander Graf <agraf@csgraf.de> > > --- > > Maybe someone with more insight into the qfw code could tell me if we can remove > the include altogether? :) > --- > drivers/misc/qfw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I'd rather have an empty file than another #ifdef. Regards, Simon
diff --git a/drivers/misc/qfw.c b/drivers/misc/qfw.c index 677841aac5..754bc6a603 100644 --- a/drivers/misc/qfw.c +++ b/drivers/misc/qfw.c @@ -15,7 +15,7 @@ #include <dm.h> #include <misc.h> #include <tables_csum.h> -#ifdef CONFIG_GENERATE_ACPI_TABLE +#if defined(CONFIG_GENERATE_ACPI_TABLE) && !defined(CONFIG_ARM) #include <asm/tables.h> #endif
asm/tables.h does not exist on ARM and I did not need it to make the code compile successfully. Let's not include it there. Signed-off-by: Alexander Graf <agraf@csgraf.de> --- Maybe someone with more insight into the qfw code could tell me if we can remove the include altogether? :) --- drivers/misc/qfw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)