| Message ID | 20220111161525.2499825-1-john@metanate.com |
|---|---|
| State | Accepted |
| Commit | 66d0b7e1f2bdcfbb7a64a0ffc1fd63617b8dd995 |
| Headers | show |
| Series | mmc: dwmmc: return a proper error code when busy | expand |
Hi John, On 1/12/22 1:15 AM, John Keeping wrote: > When failing to send a command because the hardware is busy, return > EBUSY to indicate the cause instead of just -1. > > Signed-off-by: John Keeping <john@metanate.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > drivers/mmc/dw_mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c > index a949dad574..4232c5eb8c 100644 > --- a/drivers/mmc/dw_mmc.c > +++ b/drivers/mmc/dw_mmc.c > @@ -301,7 +301,7 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, > flags = dwmci_set_transfer_mode(host, data); > > if ((cmd->resp_type & MMC_RSP_136) && (cmd->resp_type & MMC_RSP_BUSY)) > - return -1; > + return -EBUSY; > > if (cmd->cmdidx == MMC_CMD_STOP_TRANSMISSION) > flags |= DWMCI_CMD_ABORT_STOP; >
Hi John, On 1/12/22 7:12 AM, Jaehoon Chung wrote: > Hi John, > > On 1/12/22 1:15 AM, John Keeping wrote: >> When failing to send a command because the hardware is busy, return >> EBUSY to indicate the cause instead of just -1. Is this patch same? https://patchwork.ozlabs.org/project/uboot/patch/20211207160935.404395-1-john@metanate.com/ >> >> Signed-off-by: John Keeping <john@metanate.com> > > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>> > Best Regards, > Jaehoon Chung > >> --- >> drivers/mmc/dw_mmc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c >> index a949dad574..4232c5eb8c 100644 >> --- a/drivers/mmc/dw_mmc.c >> +++ b/drivers/mmc/dw_mmc.c >> @@ -301,7 +301,7 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, >> flags = dwmci_set_transfer_mode(host, data); >> >> if ((cmd->resp_type & MMC_RSP_136) && (cmd->resp_type & MMC_RSP_BUSY)) >> - return -1; >> + return -EBUSY; >> >> if (cmd->cmdidx == MMC_CMD_STOP_TRANSMISSION) >> flags |= DWMCI_CMD_ABORT_STOP; >> > >
On Wed, Jan 12, 2022 at 08:38:01AM +0900, Jaehoon Chung wrote: > On 1/12/22 7:12 AM, Jaehoon Chung wrote: > > On 1/12/22 1:15 AM, John Keeping wrote: > >> When failing to send a command because the hardware is busy, return > >> EBUSY to indicate the cause instead of just -1. > > Is this patch same? > > https://patchwork.ozlabs.org/project/uboot/patch/20211207160935.404395-1-john@metanate.com/ Yes, sorry - I still had the patch file lying around and passed the wrong filename to git send-email! > >> > >> Signed-off-by: John Keeping <john@metanate.com> > > > > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>> > > Best Regards, > > Jaehoon Chung > > > >> --- > >> drivers/mmc/dw_mmc.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c > >> index a949dad574..4232c5eb8c 100644 > >> --- a/drivers/mmc/dw_mmc.c > >> +++ b/drivers/mmc/dw_mmc.c > >> @@ -301,7 +301,7 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, > >> flags = dwmci_set_transfer_mode(host, data); > >> > >> if ((cmd->resp_type & MMC_RSP_136) && (cmd->resp_type & MMC_RSP_BUSY)) > >> - return -1; > >> + return -EBUSY; > >> > >> if (cmd->cmdidx == MMC_CMD_STOP_TRANSMISSION) > >> flags |= DWMCI_CMD_ABORT_STOP; > >> > > > > >
On 1/12/22 8:11 PM, John Keeping wrote: > On Wed, Jan 12, 2022 at 08:38:01AM +0900, Jaehoon Chung wrote: >> On 1/12/22 7:12 AM, Jaehoon Chung wrote: >>> On 1/12/22 1:15 AM, John Keeping wrote: >>>> When failing to send a command because the hardware is busy, return >>>> EBUSY to indicate the cause instead of just -1. >> >> Is this patch same? >> >> https://protect2.fireeye.com/v1/url?k=887b401c-d7e0790d-887acb53-0cc47a31cdbc-5fff461e625e1ff5&q=1&e=e07e0f85-41c3-4e09-870a-cdcb715f39aa&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Fpatch%2F20211207160935.404395-1-john%40metanate.com%2F > > Yes, sorry - I still had the patch file lying around and passed the > wrong filename to git send-email! Applied with your previous patch. Thanks! Best Regards, Jaehoon Chung > >>>> >>>> Signed-off-by: John Keeping <john@metanate.com> >>> >>> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>> >>> Best Regards, >>> Jaehoon Chung >>> >>>> --- >>>> drivers/mmc/dw_mmc.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c >>>> index a949dad574..4232c5eb8c 100644 >>>> --- a/drivers/mmc/dw_mmc.c >>>> +++ b/drivers/mmc/dw_mmc.c >>>> @@ -301,7 +301,7 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, >>>> flags = dwmci_set_transfer_mode(host, data); >>>> >>>> if ((cmd->resp_type & MMC_RSP_136) && (cmd->resp_type & MMC_RSP_BUSY)) >>>> - return -1; >>>> + return -EBUSY; >>>> >>>> if (cmd->cmdidx == MMC_CMD_STOP_TRANSMISSION) >>>> flags |= DWMCI_CMD_ABORT_STOP; >>>> >>> >>> >> >
diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index a949dad574..4232c5eb8c 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -301,7 +301,7 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, flags = dwmci_set_transfer_mode(host, data); if ((cmd->resp_type & MMC_RSP_136) && (cmd->resp_type & MMC_RSP_BUSY)) - return -1; + return -EBUSY; if (cmd->cmdidx == MMC_CMD_STOP_TRANSMISSION) flags |= DWMCI_CMD_ABORT_STOP;
When failing to send a command because the hardware is busy, return EBUSY to indicate the cause instead of just -1. Signed-off-by: John Keeping <john@metanate.com> --- drivers/mmc/dw_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)