| Message ID | 20211221123249.455347-3-pbrobinson@gmail.com |
|---|---|
| State | Accepted |
| Commit | 79ac6917d0fba793029c294fbfcb660a5a8fbdeb |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [1/4] udoo_neo: Call gpio_request() | expand |
On Tue, Dec 21, 2021 at 9:32 AM Peter Robinson <pbrobinson@gmail.com> wrote: > > The ethernet has a RMII not RGMII, also needs DM_MDIO and finally > initialise it later in the process as it's not needed that early on > and not everything is ready so it locks up the device. > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> Reviewed-by: Fabio Estevam <festevam@gmail.com>
On Tue, Dec 21, 2021 at 12:32:48PM +0000, Peter Robinson wrote: > The ethernet has a RMII not RGMII, also needs DM_MDIO and finally > initialise it later in the process as it's not needed that early on > and not everything is ready so it locks up the device. > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > Reviewed-by: Fabio Estevam <festevam@gmail.com> Applied to u-boot/master, thanks!
diff --git a/board/udoo/neo/neo.c b/board/udoo/neo/neo.c index 8b0d13b1ca..62f81fff68 100644 --- a/board/udoo/neo/neo.c +++ b/board/udoo/neo/neo.c @@ -303,6 +303,8 @@ int board_init(void) setup_i2c(0, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info1); #endif + setup_fec(); + return 0; } @@ -337,7 +339,6 @@ static int get_board_value(void) int board_early_init_f(void) { setup_iomux_uart(); - setup_fec(); return 0; } diff --git a/configs/udoo_neo_defconfig b/configs/udoo_neo_defconfig index f01d2e22e9..2a37757100 100644 --- a/configs/udoo_neo_defconfig +++ b/configs/udoo_neo_defconfig @@ -46,8 +46,8 @@ CONFIG_PHYLIB=y CONFIG_PHY_MICREL=y CONFIG_PHY_MICREL_KSZ8XXX=y CONFIG_DM_ETH=y +CONFIG_DM_MDIO=y CONFIG_FEC_MXC=y -CONFIG_RGMII=y CONFIG_MII=y CONFIG_PINCTRL=y CONFIG_PINCTRL_IMX6=y
The ethernet has a RMII not RGMII, also needs DM_MDIO and finally initialise it later in the process as it's not needed that early on and not everything is ready so it locks up the device. Signed-off-by: Peter Robinson <pbrobinson@gmail.com> --- board/udoo/neo/neo.c | 3 ++- configs/udoo_neo_defconfig | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)