diff mbox series

lib: export vsscanf

Message ID 20211220181916.28327716.samuel@dionne-riel.com
State Accepted
Commit 499f18446d2ceb4a48730e9ef3111bcbd9fae9de
Delegated to: Tom Rini
Headers show
Series lib: export vsscanf | expand

Commit Message

Samuel Dionne-Riel Dec. 20, 2021, 11:19 p.m. UTC
The function was missing from exports, even though it loooks like the
intent of the implementation in sscanf.c was to have it exported.

Signed-off-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
Cc: Simon Glass <sjg@chromium.org>
---

This is needed for porting an external library to U-Boot, in WIP
changes. It builds with a warning, and does link since the symbol is
present. Though when treating warnings as errors during development, it
becomes an issue.

 include/vsprintf.h | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Simon Glass Dec. 28, 2021, 8:33 a.m. UTC | #1
On Mon, 20 Dec 2021 at 16:19, Samuel Dionne-Riel <samuel@dionne-riel.com> wrote:
>
> The function was missing from exports, even though it loooks like the
> intent of the implementation in sscanf.c was to have it exported.
>
> Signed-off-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>
> This is needed for porting an external library to U-Boot, in WIP
> changes. It builds with a warning, and does link since the symbol is
> present. Though when treating warnings as errors during development, it
> becomes an issue.
>
>  include/vsprintf.h | 8 ++++++++
>  1 file changed, 8 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini Jan. 15, 2022, 12:38 p.m. UTC | #2
On Mon, Dec 20, 2021 at 06:19:16PM -0500, Samuel Dionne-Riel wrote:

> The function was missing from exports, even though it loooks like the
> intent of the implementation in sscanf.c was to have it exported.
> 
> Signed-off-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
> Cc: Simon Glass <sjg@chromium.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/include/vsprintf.h b/include/vsprintf.h
index b474630146..8bfafa0d33 100644
--- a/include/vsprintf.h
+++ b/include/vsprintf.h
@@ -307,6 +307,14 @@  char *strmhz(char *buf, unsigned long hz);
  */
 void str_to_upper(const char *in, char *out, size_t len);
 
+/**
+ * vsscanf - Unformat a buffer into a list of arguments
+ * @buf:	input buffer
+ * @fmt:	format of buffer
+ * @args:	arguments
+ */
+int vsscanf(const char *inp, char const *fmt0, va_list ap);
+
 /**
  * sscanf - Unformat a buffer into a list of arguments
  * @buf:	input buffer