| Message ID | 20211128150907.1443035-1-angus@akkea.ca |
|---|---|
| State | Changes Requested |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | drivers: spi-nor: Add JEDEC id for W25Q16JV | expand |
On Sun, Nov 28, 2021 at 8:39 PM Angus Ainslie <angus@akkea.ca> wrote: > > Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with > DUAL/QUAD SPI > > Signed-off-by: Angus Ainslie <angus@akkea.ca> > --- > drivers/mtd/spi/spi-nor-ids.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c > index 3ae7bb1ed7e..f20b21e0d06 100644 > --- a/drivers/mtd/spi/spi-nor-ids.c > +++ b/drivers/mtd/spi/spi-nor-ids.c > @@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = { > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > }, > + { > + INFO("w25q16jv", 0xef7015, 0, 64 * 1024, 32, > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) Look like this part is same for im/jm suffix parts. would you update the name to use that - "w25q16jv-im/jm" Jagan.
Hi, Are there any problems with this patch ? Thanks Angus On 2021-11-28 07:09, Angus Ainslie wrote: > Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory > with > DUAL/QUAD SPI > > Signed-off-by: Angus Ainslie <angus@akkea.ca> > --- > drivers/mtd/spi/spi-nor-ids.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/spi/spi-nor-ids.c > b/drivers/mtd/spi/spi-nor-ids.c > index 3ae7bb1ed7e..f20b21e0d06 100644 > --- a/drivers/mtd/spi/spi-nor-ids.c > +++ b/drivers/mtd/spi/spi-nor-ids.c > @@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = { > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > }, > + { > + INFO("w25q16jv", 0xef7015, 0, 64 * 1024, 32, > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > + }, > { > INFO("w25q32jv", 0xef7016, 0, 64 * 1024, 64, > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
Hi Jagan, On 2021-12-01 21:59, Jagan Teki wrote: > On Sun, Nov 28, 2021 at 8:39 PM Angus Ainslie <angus@akkea.ca> wrote: >> >> Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory >> with >> DUAL/QUAD SPI >> >> Signed-off-by: Angus Ainslie <angus@akkea.ca> >> --- >> drivers/mtd/spi/spi-nor-ids.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/mtd/spi/spi-nor-ids.c >> b/drivers/mtd/spi/spi-nor-ids.c >> index 3ae7bb1ed7e..f20b21e0d06 100644 >> --- a/drivers/mtd/spi/spi-nor-ids.c >> +++ b/drivers/mtd/spi/spi-nor-ids.c >> @@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = { >> SECT_4K | SPI_NOR_DUAL_READ | >> SPI_NOR_QUAD_READ | >> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) >> }, >> + { >> + INFO("w25q16jv", 0xef7015, 0, 64 * 1024, 32, >> + SECT_4K | SPI_NOR_DUAL_READ | >> SPI_NOR_QUAD_READ | >> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > > Look like this part is same for im/jm suffix parts. would you update > the name to use that - "w25q16jv-im/jm" > Sorry I missed this email I'll send an update. Angus > Jagan.
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index 3ae7bb1ed7e..f20b21e0d06 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c @@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = { SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) }, + { + INFO("w25q16jv", 0xef7015, 0, 64 * 1024, 32, + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) + }, { INFO("w25q32jv", 0xef7016, 0, 64 * 1024, 64, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with DUAL/QUAD SPI Signed-off-by: Angus Ainslie <angus@akkea.ca> --- drivers/mtd/spi/spi-nor-ids.c | 5 +++++ 1 file changed, 5 insertions(+)