| Message ID | 20211102140558.32460-5-sinthu.raja@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Add support for J721E SK | expand |
On Tue, Nov 02, 2021 at 07:35:45PM +0530, Sinthu Raja wrote: > From: Sinthu Raja <sinthu.raja@ti.com> > > board_late_init(), setup_board_eeprom_env() and setup_serial() is > called only under CONFIG_BOARD_LATE_INIT, so guard these functions > with the same. > > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com> > --- > > No chnages in V2. > > board/ti/j721e/evm.c | 4 ++++ > 1 file changed, 4 insertions(+) We should probably re-order the code so that everything is under a single #ifdef.
diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c index 077d83420c..9cdb963221 100644 --- a/board/ti/j721e/evm.c +++ b/board/ti/j721e/evm.c @@ -172,6 +172,7 @@ int checkboard(void) return 0; } +#ifdef CONFIG_BOARD_LATE_INIT static void setup_board_eeprom_env(void) { char *name = "j721e"; @@ -210,6 +211,7 @@ static void setup_serial(void) snprintf(serial_string, sizeof(serial_string), "%016lx", board_serial); env_set("serial#", serial_string); } +#endif /* * Declaration of daughtercards to probe. Note that when adding more @@ -413,6 +415,7 @@ void configure_serdes_torrent(void) printf("phy_power_on failed !!\n"); } +#ifdef CONFIG_BOARD_LATE_INIT int board_late_init(void) { if (IS_ENABLED(CONFIG_TI_I2C_BOARD_DETECT)) { @@ -428,6 +431,7 @@ int board_late_init(void) return 0; } +#endif void spl_board_init(void) {