diff mbox series

[05/12] lmb: arm: Increase LMB alignment to 16k in arch_lmb_reserve_generic()

Message ID 20210910204718.17765-5-marek.vasut+renesas@gmail.com
State Accepted
Commit b1d0487cfe8dfaa5c4124bbe504b120b705f2d8e
Delegated to: Tom Rini
Headers show
Series [01/12] lmb: Always compile arch_lmb_reserve() into U-Boot on arm | expand

Commit Message

Marek Vasut Sept. 10, 2021, 8:47 p.m. UTC
According to input NXP, the 4k alignment is not always sufficient.
Currently iMX works around this problem by implementing board specific
LMB reservation, however it is likely this could also occur on other
systems. Increase the LMB reservation alignment to 16k by default.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Alexey Brodkin <alexey.brodkin@synopsys.com>
Cc: Angelo Dureghello <angelo@sysam.it>
Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: Hai Pham <hai.pham.ud@renesas.com>
Cc: Michal Simek <monstr@monstr.eu>
Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Cc: Tom Rini <trini@konsulko.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Ye Li <ye.li@nxp.com>
---
V2: New patch
---
 arch/arm/lib/stack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Sept. 10, 2021, 9:10 p.m. UTC | #1
On Fri, Sep 10, 2021 at 10:47:11PM +0200, Marek Vasut wrote:

> According to input NXP, the 4k alignment is not always sufficient.
> Currently iMX works around this problem by implementing board specific
> LMB reservation, however it is likely this could also occur on other
> systems. Increase the LMB reservation alignment to 16k by default.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Alexey Brodkin <alexey.brodkin@synopsys.com>
> Cc: Angelo Dureghello <angelo@sysam.it>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> Cc: Hai Pham <hai.pham.ud@renesas.com>
> Cc: Michal Simek <monstr@monstr.eu>
> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Ye Li <ye.li@nxp.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
Tom Rini Sept. 24, 2021, 2:42 a.m. UTC | #2
On Fri, Sep 10, 2021 at 10:47:11PM +0200, Marek Vasut wrote:

> According to input NXP, the 4k alignment is not always sufficient.
> Currently iMX works around this problem by implementing board specific
> LMB reservation, however it is likely this could also occur on other
> systems. Increase the LMB reservation alignment to 16k by default.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Alexey Brodkin <alexey.brodkin@synopsys.com>
> Cc: Angelo Dureghello <angelo@sysam.it>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> Cc: Hai Pham <hai.pham.ud@renesas.com>
> Cc: Michal Simek <monstr@monstr.eu>
> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Ye Li <ye.li@nxp.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/arch/arm/lib/stack.c b/arch/arm/lib/stack.c
index 52d9f15298..656084c7e5 100644
--- a/arch/arm/lib/stack.c
+++ b/arch/arm/lib/stack.c
@@ -45,5 +45,5 @@  static ulong get_sp(void)
 
 void arch_lmb_reserve(struct lmb *lmb)
 {
-	arch_lmb_reserve_generic(lmb, get_sp(), gd->ram_top, 4096);
+	arch_lmb_reserve_generic(lmb, get_sp(), gd->ram_top, 16384);
 }