| Message ID | 20210906205753.176175-3-arnaud.ferraris@collabora.com |
|---|---|
| State | Superseded |
| Delegated to: | Andre Przywara |
| Headers | show |
| Series | [1/2] board: sunxi: enable status LED early | expand |
On Mon, 6 Sep 2021 22:57:53 +0200 Arnaud Ferraris <arnaud.ferraris@collabora.com> wrote: > From: Arnaud Ferraris <arnaud.ferraris@gmail.com> > > This commit enables the green status LED (PD18/GPIO 114) on boot in the > SPL, in order to provide visual feedback that the PinePhone is booting. Looks alright, and while I don't have a Pinephone to test this, I tried the similar setting on a Pine64-LTS. It should be noted that this increases the SPL by 364 bytes (in my setup), which kills the Pine H64, for instance. But it looks fine for A64 boards. > Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > configs/pinephone_defconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/configs/pinephone_defconfig b/configs/pinephone_defconfig > index 64e13d3132..9d39204a43 100644 > --- a/configs/pinephone_defconfig > +++ b/configs/pinephone_defconfig > @@ -1,6 +1,7 @@ > CONFIG_ARM=y > CONFIG_ARCH_SUNXI=y > CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pinephone-1.2" > +CONFIG_SPL_DRIVERS_MISC=y > CONFIG_SPL=y > CONFIG_MACH_SUN50I=y > CONFIG_SUNXI_DRAM_LPDDR3_STOCK=y > @@ -10,3 +11,8 @@ CONFIG_MMC_SUNXI_SLOT_EXTRA=2 > CONFIG_PINEPHONE_DT_SELECTION=y > # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set > CONFIG_OF_LIST="sun50i-a64-pinephone-1.1 sun50i-a64-pinephone-1.2" > +CONFIG_LED_STATUS=y > +CONFIG_LED_STATUS_GPIO=y > +CONFIG_LED_STATUS0=y > +CONFIG_LED_STATUS_BIT=114 > +CONFIG_LED_STATUS_STATE=2
diff --git a/configs/pinephone_defconfig b/configs/pinephone_defconfig index 64e13d3132..9d39204a43 100644 --- a/configs/pinephone_defconfig +++ b/configs/pinephone_defconfig @@ -1,6 +1,7 @@ CONFIG_ARM=y CONFIG_ARCH_SUNXI=y CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pinephone-1.2" +CONFIG_SPL_DRIVERS_MISC=y CONFIG_SPL=y CONFIG_MACH_SUN50I=y CONFIG_SUNXI_DRAM_LPDDR3_STOCK=y @@ -10,3 +11,8 @@ CONFIG_MMC_SUNXI_SLOT_EXTRA=2 CONFIG_PINEPHONE_DT_SELECTION=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_OF_LIST="sun50i-a64-pinephone-1.1 sun50i-a64-pinephone-1.2" +CONFIG_LED_STATUS=y +CONFIG_LED_STATUS_GPIO=y +CONFIG_LED_STATUS0=y +CONFIG_LED_STATUS_BIT=114 +CONFIG_LED_STATUS_STATE=2