| Message ID | 20210730121253.1.I548969a35a3522881113dc073f34b86bb15d29a6@changeid |
|---|---|
| State | Accepted |
| Commit | b18b38f2ae3f54b906e0f2ab86789d9dd0110ed2 |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | dm: migrate the dm_warn to use the log macro | expand |
On Fri, 30 Jul 2021 at 04:13, Patrick Delaunay <patrick.delaunay@foss.st.com> wrote: > > Migrate the dm_warn function to log macro with > LOGC_DM category and LOGL_WARNING level. > > This macro allows filtering with log command and allows > output on all log backend. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > drivers/core/util.c | 11 ----------- > include/dm/util.h | 2 +- > 2 files changed, 1 insertion(+), 12 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Fri, 30 Jul 2021 at 04:13, Patrick Delaunay <patrick.delaunay@foss.st.com> wrote: > > Migrate the dm_warn function to log macro with > LOGC_DM category and LOGL_WARNING level. > > This macro allows filtering with log command and allows > output on all log backend. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > drivers/core/util.c | 11 ----------- > include/dm/util.h | 2 +- > 2 files changed, 1 insertion(+), 12 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot-dm, thanks!
diff --git a/drivers/core/util.c b/drivers/core/util.c index 91e93b0cf1..5be4ee79de 100644 --- a/drivers/core/util.c +++ b/drivers/core/util.c @@ -11,17 +11,6 @@ #include <linux/libfdt.h> #include <vsprintf.h> -#if CONFIG_IS_ENABLED(DM_WARN) -void dm_warn(const char *fmt, ...) -{ - va_list args; - - va_start(args, fmt); - vprintf(fmt, args); - va_end(args); -} -#endif - int list_count_items(struct list_head *head) { struct list_head *node; diff --git a/include/dm/util.h b/include/dm/util.h index 138893c935..c634e470e7 100644 --- a/include/dm/util.h +++ b/include/dm/util.h @@ -7,7 +7,7 @@ #define __DM_UTIL_H #if CONFIG_IS_ENABLED(DM_WARN) -void dm_warn(const char *fmt, ...); +#define dm_warn(fmt...) log(LOGC_DM, LOGL_WARNING, ##fmt) #else static inline void dm_warn(const char *fmt, ...) {
Migrate the dm_warn function to log macro with LOGC_DM category and LOGL_WARNING level. This macro allows filtering with log command and allows output on all log backend. Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> --- drivers/core/util.c | 11 ----------- include/dm/util.h | 2 +- 2 files changed, 1 insertion(+), 12 deletions(-)