| Message ID | 20210715043854.28310-1-elly.siew.chin.lim@intel.com |
|---|---|
| State | Accepted |
| Commit | 8f20c480799c54f2ff6ee9ef3d735c342bca8054 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | command: Fix SMC and HVC maximum number of arguments | expand |
On Wed, 14 Jul 2021 at 22:39, Siew Chin Lim <elly.siew.chin.lim@intel.com> wrote: > > smc and hvc commands take upto 8 user input arguments, the maximum > number of arguments of the U_BOOT_CMD macro should set to 9. > > Besides, fix the typo (arg7 -> arg6) in hvc command's help message. > > Signed-off-by: Siew Chin Lim <elly.siew.chin.lim@intel.com> > --- > cmd/smccc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Simon Glass <sjg@chromium.org>
On Thu, Jul 15, 2021 at 12:38:54PM +0800, Siew Chin Lim wrote: > smc and hvc commands take upto 8 user input arguments, the maximum > number of arguments of the U_BOOT_CMD macro should set to 9. > > Besides, fix the typo (arg7 -> arg6) in hvc command's help message. > > Signed-off-by: Siew Chin Lim <elly.siew.chin.lim@intel.com> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/cmd/smccc.c b/cmd/smccc.c index 0b19f6c68c..0ff9a08021 100644 --- a/cmd/smccc.c +++ b/cmd/smccc.c @@ -50,7 +50,7 @@ static int do_call(struct cmd_tbl *cmdtp, int flag, int argc, #ifdef CONFIG_CMD_SMC U_BOOT_CMD( - smc, 8, 2, do_call, + smc, 9, 2, do_call, "Issue a Secure Monitor Call", "<fid> [arg1 ... arg6] [id]\n" " - fid Function ID\n" @@ -61,9 +61,9 @@ U_BOOT_CMD( #ifdef CONFIG_CMD_HVC U_BOOT_CMD( - hvc, 8, 2, do_call, + hvc, 9, 2, do_call, "Issue a Hypervisor Call", - "<fid> [arg1...arg7] [id]\n" + "<fid> [arg1...arg6] [id]\n" " - fid Function ID\n" " - arg HVC arguments, passed to X1-X6 (default to zero)\n" " - id Session ID, passed to W7 (defaults to zero)\n"
smc and hvc commands take upto 8 user input arguments, the maximum number of arguments of the U_BOOT_CMD macro should set to 9. Besides, fix the typo (arg7 -> arg6) in hvc command's help message. Signed-off-by: Siew Chin Lim <elly.siew.chin.lim@intel.com> --- cmd/smccc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)