| Message ID | 20210702160013.89038-1-stephan@gerhold.net |
|---|---|
| State | Accepted |
| Commit | 0e6956cc7d5c3f050544a268746d79e342d8a40d |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | timer: nomadik-mtu: Use dev_read_addr_ptr() | expand |
On Fri, Jul 2, 2021 at 6:00 PM Stephan Gerhold <stephan@gerhold.net> wrote: > Simplify the code a bit by using dev_read_addr_ptr() instead of > dev_read_addr(). This avoids having to cast explicitly to the > struct nomadik_mtu_regs. > > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, Jul 02, 2021 at 06:00:13PM +0200, Stephan Gerhold wrote: > Simplify the code a bit by using dev_read_addr_ptr() instead of > dev_read_addr(). This avoids having to cast explicitly to the > struct nomadik_mtu_regs. > > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Applied to u-boot/master, thanks!
diff --git a/drivers/timer/nomadik-mtu-timer.c b/drivers/timer/nomadik-mtu-timer.c index 417b419d46..4d24de14ae 100644 --- a/drivers/timer/nomadik-mtu-timer.c +++ b/drivers/timer/nomadik-mtu-timer.c @@ -67,14 +67,11 @@ static int nomadik_mtu_probe(struct udevice *dev) struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); struct nomadik_mtu_priv *priv = dev_get_priv(dev); struct nomadik_mtu_regs *mtu; - fdt_addr_t addr; u32 prescale; - addr = dev_read_addr(dev); - if (addr == FDT_ADDR_T_NONE) + mtu = dev_read_addr_ptr(dev); + if (!mtu) return -EINVAL; - - mtu = (struct nomadik_mtu_regs *)addr; priv->timer = mtu->timers; /* Use first timer */ if (!uc_priv->clock_rate)
Simplify the code a bit by using dev_read_addr_ptr() instead of dev_read_addr(). This avoids having to cast explicitly to the struct nomadik_mtu_regs. Signed-off-by: Stephan Gerhold <stephan@gerhold.net> --- drivers/timer/nomadik-mtu-timer.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)