| Message ID | 20210629170839.2583797-7-olteanv@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Priyanka Jain |
| Headers | show |
| Series | Call phy_config at port probe time for the Felix DSA driver | expand |
On Tue, Jun 29, 2021 at 8:09 PM Vladimir Oltean <olteanv@gmail.com> wrote: > > From: Vladimir Oltean <vladimir.oltean@nxp.com> > > Make sure that the link status returned by phy_startup() is propagated > to the .start() method of struct eth_ops. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > --- > drivers/net/mscc_eswitch/felix_switch.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c > index c8ecf4f19442..6aa79784460d 100644 > --- a/drivers/net/mscc_eswitch/felix_switch.c > +++ b/drivers/net/mscc_eswitch/felix_switch.c > @@ -352,9 +352,7 @@ static int felix_port_enable(struct udevice *dev, int port, > FELIX_QSYS_SYSTEM_SW_PORT_LOSSY | > FELIX_QSYS_SYSTEM_SW_PORT_SCH(1)); > > - phy_startup(phy); > - > - return 0; > + return phy_startup(phy); > } > > static void felix_port_disable(struct udevice *dev, int pidx, > -- > 2.25.1 > Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c index c8ecf4f19442..6aa79784460d 100644 --- a/drivers/net/mscc_eswitch/felix_switch.c +++ b/drivers/net/mscc_eswitch/felix_switch.c @@ -352,9 +352,7 @@ static int felix_port_enable(struct udevice *dev, int port, FELIX_QSYS_SYSTEM_SW_PORT_LOSSY | FELIX_QSYS_SYSTEM_SW_PORT_SCH(1)); - phy_startup(phy); - - return 0; + return phy_startup(phy); } static void felix_port_disable(struct udevice *dev, int pidx,