diff mbox series

[1/2] i2c: pcf8575: Remove not used members of pcf8575_chip structure

Message ID 20210607122634.19556-1-lukma@denx.de
State Accepted
Commit 0119c910521cd6b089e5c3ec623902caf75b4915
Delegated to: Tom Rini
Headers show
Series [1/2] i2c: pcf8575: Remove not used members of pcf8575_chip structure | expand

Commit Message

Lukasz Majewski June 7, 2021, 12:26 p.m. UTC
Those members are not used anymore as ones from gpio_dev_priv
structure (when DM_GPIO support is enabled) are used instead.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---

 drivers/gpio/pcf8575_gpio.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Heiko Schocher June 19, 2021, 8:36 a.m. UTC | #1
Hello Lukasz,

On 07.06.21 14:26, Lukasz Majewski wrote:
> Those members are not used anymore as ones from gpio_dev_priv
> structure (when DM_GPIO support is enabled) are used instead.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
> 
>  drivers/gpio/pcf8575_gpio.c | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
Tom Rini July 23, 2021, 12:34 p.m. UTC | #2
On Mon, Jun 07, 2021 at 02:26:33PM +0200, Lukasz Majewski wrote:

> Those members are not used anymore as ones from gpio_dev_priv
> structure (when DM_GPIO support is enabled) are used instead.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> Reviewed-by: Heiko Schocher <hs@denx.de>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/gpio/pcf8575_gpio.c b/drivers/gpio/pcf8575_gpio.c
index 359646266c93..bae9695f28b1 100644
--- a/drivers/gpio/pcf8575_gpio.c
+++ b/drivers/gpio/pcf8575_gpio.c
@@ -34,8 +34,6 @@ 
 DECLARE_GLOBAL_DATA_PTR;
 
 struct pcf8575_chip {
-	int gpio_count;		/* No. GPIOs supported by the chip */
-
 	/* NOTE:  these chips have strange "quasi-bidirectional" I/O pins.
 	 * We can't actually know whether a pin is configured (a) as output
 	 * and driving the signal low, or (b) as input and reporting a low
@@ -49,7 +47,6 @@  struct pcf8575_chip {
 	 * reset state.  Otherwise it flags pins to be driven low.
 	 */
 	unsigned int out;	/* software latch */
-	const char *bank_name;	/* Name of the expander bank */
 };
 
 /* Read/Write to 16-bit I/O expander */