| Message ID | 20210521195945.1102417-1-harm.berntsen@nedap.com |
|---|---|
| State | Accepted |
| Commit | b725ed50714ff817cc0d8ccbc9c3655032587382 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | GitLab: Remove tags for sandbox_noinst tests | expand |
On 21/05/21 09:59PM, Harm Berntsen wrote: > Commit 712cc962b70d ("GitLab: Remove "tags" stanzas") removed the 'all' > tag from all the jobs. The sandbox_noinst_test.py test was added in > between the author date and commit date (commit 6c914e4232cd > ("azure/gitlab: Add tests for sandbox_noinst")) which is probably why it > still contains the tags. This commit fixes that so all jobs now don't > require tags on the GitLab runners. I have been running this diff locally for some time now to allow GitLab runners to complete the tests. Not well versed enough with these CI/CD tools to know if this was a good idea or not so I never sent a patch. Acked-by: Pratyush Yadav <p.yadav@ti.com>
On Fri, May 21, 2021 at 09:59:45PM +0200, Harm Berntsen wrote: > Commit 712cc962b70d ("GitLab: Remove "tags" stanzas") removed the 'all' > tag from all the jobs. The sandbox_noinst_test.py test was added in > between the author date and commit date (commit 6c914e4232cd > ("azure/gitlab: Add tests for sandbox_noinst")) which is probably why it > still contains the tags. This commit fixes that so all jobs now don't > require tags on the GitLab runners. > > Signed-off-by: Harm Berntsen <harm.berntsen@nedap.com> > CC: Simon Glass <sjg@chromium.org> > Acked-by: Pratyush Yadav <p.yadav@ti.com> Applied to u-boot/master, thanks!
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index bff487404f..4e21fca10f 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -189,7 +189,6 @@ sandbox_spl test.py: <<: *buildman_and_testpy_dfn sandbox_noinst_test.py: - tags: [ 'all' ] variables: TEST_PY_BD: "sandbox_noinst" TEST_PY_TEST_SPEC: "test_ofplatdata or test_handoff or test_spl"
Commit 712cc962b70d ("GitLab: Remove "tags" stanzas") removed the 'all' tag from all the jobs. The sandbox_noinst_test.py test was added in between the author date and commit date (commit 6c914e4232cd ("azure/gitlab: Add tests for sandbox_noinst")) which is probably why it still contains the tags. This commit fixes that so all jobs now don't require tags on the GitLab runners. Signed-off-by: Harm Berntsen <harm.berntsen@nedap.com> CC: Simon Glass <sjg@chromium.org> --- .gitlab-ci.yml | 1 - 1 file changed, 1 deletion(-)