| Message ID | 20210511074015.24272-1-kristo@kernel.org |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | configs: ti: enable TFTP_SIZE | expand |
On Tue, May 11, 2021 at 10:40:15AM +0300, Tero Kristo wrote: > This fits the TFTP progress bar on single line based on the size of the > file being downloaded, reducing unnecessary spam and also making it > easier to track the download progress. > > Signed-off-by: Tero Kristo <kristo@kernel.org> > --- > include/configs/ti_armv7_common.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h > index f13e9e5264..f40089a3fd 100644 > --- a/include/configs/ti_armv7_common.h > +++ b/include/configs/ti_armv7_common.h > @@ -205,6 +205,8 @@ > "run netloadfdt; " \ > "run netargs; " \ > "bootz ${loadaddr} - ${fdtaddr}\0" > + > +#define CONFIG_TFTP_TSIZE > #else > #define NETARGS "" > #endif That's pretty handy. Can you please convert it to Kconfig (it should go in net/Kconfig) and default y if ARCH_OMAP2PLUS should be fine. Thanks.
On 11/05/2021 15:07, Tom Rini wrote: > On Tue, May 11, 2021 at 10:40:15AM +0300, Tero Kristo wrote: > >> This fits the TFTP progress bar on single line based on the size of the >> file being downloaded, reducing unnecessary spam and also making it >> easier to track the download progress. >> >> Signed-off-by: Tero Kristo <kristo@kernel.org> >> --- >> include/configs/ti_armv7_common.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h >> index f13e9e5264..f40089a3fd 100644 >> --- a/include/configs/ti_armv7_common.h >> +++ b/include/configs/ti_armv7_common.h >> @@ -205,6 +205,8 @@ >> "run netloadfdt; " \ >> "run netargs; " \ >> "bootz ${loadaddr} - ${fdtaddr}\0" >> + >> +#define CONFIG_TFTP_TSIZE >> #else >> #define NETARGS "" >> #endif > > That's pretty handy. Can you please convert it to Kconfig (it should go > in net/Kconfig) and default y if ARCH_OMAP2PLUS should be fine. Thanks. > Yea, I can take a shot at that. -Tero
diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h index f13e9e5264..f40089a3fd 100644 --- a/include/configs/ti_armv7_common.h +++ b/include/configs/ti_armv7_common.h @@ -205,6 +205,8 @@ "run netloadfdt; " \ "run netargs; " \ "bootz ${loadaddr} - ${fdtaddr}\0" + +#define CONFIG_TFTP_TSIZE #else #define NETARGS "" #endif
This fits the TFTP progress bar on single line based on the size of the file being downloaded, reducing unnecessary spam and also making it easier to track the download progress. Signed-off-by: Tero Kristo <kristo@kernel.org> --- include/configs/ti_armv7_common.h | 2 ++ 1 file changed, 2 insertions(+)