| Message ID | 20210412042155.710033-1-seanga2@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | checkpatch: Ignore ENOSYS warnings | expand |
Hi Sean, On Mon, 12 Apr 2021 at 16:22, Sean Anderson <seanga2@gmail.com> wrote: > > There are no system calls in U-Boot, but ENOSYS is still allowed (and > preferred since 42a2668743 ("dm: core: Document the common error codes")). > Silence this warning. > > Signed-off-by: Sean Anderson <seanga2@gmail.com> > Seriies-to: sjg This looks OK, except for that tag. Regards, Simon > --- > > .checkpatch.conf | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/.checkpatch.conf b/.checkpatch.conf > index ed0c2150ba..9e40ea060b 100644 > --- a/.checkpatch.conf > +++ b/.checkpatch.conf > @@ -26,6 +26,9 @@ > # addresses are __aligned(2)". > --ignore PREFER_ETHER_ADDR_COPY > > +# ENOSYS is a conventionally used error, even though U-Boot lacks system calls. > +--ignore ENOSYS > + > # A bit shorter of a description is OK with us. > --min-conf-desc-length=2 > > -- > 2.31.0 >
On 4/12/21 2:04 PM, Simon Glass wrote: > Hi Sean, > > On Mon, 12 Apr 2021 at 16:22, Sean Anderson <seanga2@gmail.com> wrote: >> >> There are no system calls in U-Boot, but ENOSYS is still allowed (and >> preferred since 42a2668743 ("dm: core: Document the common error codes")). >> Silence this warning. >> >> Signed-off-by: Sean Anderson <seanga2@gmail.com> >> Seriies-to: sjg > > This looks OK, except for that tag. Should I resend the patch? --Sean > > Regards, > Simon > > >> --- >> >> .checkpatch.conf | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/.checkpatch.conf b/.checkpatch.conf >> index ed0c2150ba..9e40ea060b 100644 >> --- a/.checkpatch.conf >> +++ b/.checkpatch.conf >> @@ -26,6 +26,9 @@ >> # addresses are __aligned(2)". >> --ignore PREFER_ETHER_ADDR_COPY >> >> +# ENOSYS is a conventionally used error, even though U-Boot lacks system calls. >> +--ignore ENOSYS >> + >> # A bit shorter of a description is OK with us. >> --min-conf-desc-length=2 >> >> -- >> 2.31.0 >>
Hi Sean, On Tue, 13 Apr 2021 at 00:31, Sean Anderson <seanga2@gmail.com> wrote: > > On 4/12/21 2:04 PM, Simon Glass wrote: > > Hi Sean, > > > > On Mon, 12 Apr 2021 at 16:22, Sean Anderson <seanga2@gmail.com> wrote: > >> > >> There are no system calls in U-Boot, but ENOSYS is still allowed (and > >> preferred since 42a2668743 ("dm: core: Document the common error codes")). > >> Silence this warning. > >> > >> Signed-off-by: Sean Anderson <seanga2@gmail.com> > >> Seriies-to: sjg > > > > This looks OK, except for that tag. > > Should I resend the patch? Yes I think that would be easiest. Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/.checkpatch.conf b/.checkpatch.conf index ed0c2150ba..9e40ea060b 100644 --- a/.checkpatch.conf +++ b/.checkpatch.conf @@ -26,6 +26,9 @@ # addresses are __aligned(2)". --ignore PREFER_ETHER_ADDR_COPY +# ENOSYS is a conventionally used error, even though U-Boot lacks system calls. +--ignore ENOSYS + # A bit shorter of a description is OK with us. --min-conf-desc-length=2
There are no system calls in U-Boot, but ENOSYS is still allowed (and preferred since 42a2668743 ("dm: core: Document the common error codes")). Silence this warning. Signed-off-by: Sean Anderson <seanga2@gmail.com> Seriies-to: sjg --- .checkpatch.conf | 3 +++ 1 file changed, 3 insertions(+)