diff mbox series

[1/1] cmd: CMD_USB depends on USB

Message ID 20210404133507.9364-1-xypron.glpk@gmx.de
State Accepted
Commit 7823ba339730368a63f64998cf8b81404249aa4c
Headers show
Series [1/1] cmd: CMD_USB depends on USB | expand

Commit Message

Heinrich Schuchardt April 4, 2021, 1:35 p.m. UTC 
The usb command cannot be compiled with CONFIG_USB=n:

ld.bfd: cmd/usb.c:660: undefined reference to `usb_stop'
ld.bfd: cmd/usb.c:663: undefined reference to `usb_started'

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

--
2.31.0

Comments

Marek Vasut April 4, 2021, 1:41 p.m. UTC | #1 
On 4/4/21 3:35 PM, Heinrich Schuchardt wrote:
> The usb command cannot be compiled with CONFIG_USB=n:
> 
> ld.bfd: cmd/usb.c:660: undefined reference to `usb_stop'
> ld.bfd: cmd/usb.c:663: undefined reference to `usb_started'
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Reviewed-by: Marek Vasut <marex@denx.de>

It would be nice to include this in current release, since it's 
obviously a bugfix.
Tom Rini April 4, 2021, 11:16 p.m. UTC | #2 
On Sun, Apr 04, 2021 at 01:35:07PM +0000, Heinrich Schuchardt wrote:

> The usb command cannot be compiled with CONFIG_USB=n:
> 
> ld.bfd: cmd/usb.c:660: undefined reference to `usb_stop'
> ld.bfd: cmd/usb.c:663: undefined reference to `usb_started'
> 
> Reviewed-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/cmd/Kconfig b/cmd/Kconfig
index eff238cb38..863b7f9fda 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1309,6 +1309,7 @@  config CMD_UNIVERSE

 config CMD_USB
 	bool "usb"
+	depends on USB
 	select HAVE_BLOCK_DEVICE
 	help
 	  USB support.