| Message ID | 20201226210409.28073-1-pali@kernel.org |
|---|---|
| State | Rejected, archived |
| Delegated to: | Heinrich Schuchardt |
| Headers | show |
| Series | bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE | expand |
Hi Paul, On Sat, 26 Dec 2020 at 14:04, Pali Rohár <pali@kernel.org> wrote: > > CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled > CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work. > > Define this dependency in Kconfig and remove information about this > requirement from documentation file. > > Signed-off-by: Pali Rohár <pali@kernel.org> > --- > cmd/Kconfig | 1 + > doc/usage/bootmenu.rst | 5 ----- > 2 files changed, 1 insertion(+), 5 deletions(-) This driver is past the driver model migration deadline so we shouldn't accept patches, except perhaps to migrate or remove it. Regards, Simon
On 12/29/20 4:32 AM, Simon Glass wrote: > Hi Paul, > > On Sat, 26 Dec 2020 at 14:04, Pali Rohár <pali@kernel.org> wrote: >> >> CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled >> CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work. >> >> Define this dependency in Kconfig and remove information about this >> requirement from documentation file. >> >> Signed-off-by: Pali Rohár <pali@kernel.org> >> --- >> cmd/Kconfig | 1 + >> doc/usage/bootmenu.rst | 5 ----- >> 2 files changed, 1 insertion(+), 5 deletions(-) > > This driver is past the driver model migration deadline so we > shouldn't accept patches, except perhaps to migrate or remove it. All boards selecting CONFIG_CFB_CONSOLE also select CONFIG_CFB_CONSOLE_ANSI. So this change probably is not needed for existing boards. CONFIG_CFB_CONSOLE_ANSI=y is mentioned in doc/usage/bootmenu.rst. Why does CMD_BOOTMENU not select CONFIG_VIDEO_ANSI which is the setting used by all driver model video drivers? Shouldn't that setting be mentioned in doc/usage/bootmenu.rst? Best regards Heinrich
On Tuesday 29 December 2020 11:42:56 Heinrich Schuchardt wrote: > On 12/29/20 4:32 AM, Simon Glass wrote: > > Hi Paul, > > > > On Sat, 26 Dec 2020 at 14:04, Pali Rohár <pali@kernel.org> wrote: > > > > > > CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled > > > CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work. > > > > > > Define this dependency in Kconfig and remove information about this > > > requirement from documentation file. > > > > > > Signed-off-by: Pali Rohár <pali@kernel.org> > > > --- > > > cmd/Kconfig | 1 + > > > doc/usage/bootmenu.rst | 5 ----- > > > 2 files changed, 1 insertion(+), 5 deletions(-) > > > > This driver is past the driver model migration deadline so we > > shouldn't accept patches, except perhaps to migrate or remove it. > > All boards selecting CONFIG_CFB_CONSOLE also select > CONFIG_CFB_CONSOLE_ANSI. So this change probably is not needed for > existing boards. CONFIG_CFB_CONSOLE_ANSI=y is mentioned in > doc/usage/bootmenu.rst. That is because I added this "hint" into Kconfig. So it does not have to be specified in documentation rst file. > Why does CMD_BOOTMENU not select CONFIG_VIDEO_ANSI which is the setting > used by all driver model video drivers? Shouldn't that setting be > mentioned in doc/usage/bootmenu.rst? Because I did not know about this option. It was not mentioned in documentation rst file.
diff --git a/cmd/Kconfig b/cmd/Kconfig index 1595de999b..02c28c68bd 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -279,6 +279,7 @@ source lib/efi_selftest/Kconfig config CMD_BOOTMENU bool "bootmenu" select MENU + select CFB_CONSOLE_ANSI if CFB_CONSOLE help Add an ANSI terminal boot menu command. diff --git a/doc/usage/bootmenu.rst b/doc/usage/bootmenu.rst index 1f094ad6ed..1016ac8ceb 100644 --- a/doc/usage/bootmenu.rst +++ b/doc/usage/bootmenu.rst @@ -88,8 +88,3 @@ To run the bootmenu at startup add these additional settings:: CONFIG_AUTOBOOT_KEYED=y CONFIG_BOOTDELAY=30 CONFIG_AUTOBOOT_MENU_SHOW=y - -When you intend to use the bootmenu on a color frame buffer console, -make sure to additionally define:: - - CONFIG_CFB_CONSOLE_ANSI=y
CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work. Define this dependency in Kconfig and remove information about this requirement from documentation file. Signed-off-by: Pali Rohár <pali@kernel.org> --- cmd/Kconfig | 1 + doc/usage/bootmenu.rst | 5 ----- 2 files changed, 1 insertion(+), 5 deletions(-)