diff mbox series

[v2] i2c: mxc_i2c: improve error message readability

Message ID 20201221145016.3604331-1-ferlandm@amotus.ca
State Accepted
Commit 26c7048dd9d04158a23e9dbfe3f0dccc4febcaed
Delegated to: Stefano Babic
Headers show
Series [v2] i2c: mxc_i2c: improve error message readability | expand

Commit Message

ferlandm@amotus.ca Dec. 21, 2020, 2:50 p.m. UTC 
From: Marc Ferland <ferlandm@amotus.ca>

Use 0x%2lx to print the i2c bus base address in hexadecimal format
instead of printing as an integer.

Signed-off-by: Marc Ferland <ferlandm@amotus.ca>
---
Changes for v2:
   - Add commit message

 drivers/i2c/mxc_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam Dec. 21, 2020, 8:21 p.m. UTC | #1 
On Mon, Dec 21, 2020 at 5:19 PM <ferlandm@amotus.ca> wrote:
>
> From: Marc Ferland <ferlandm@amotus.ca>
>
> Use 0x%2lx to print the i2c bus base address in hexadecimal format
> instead of printing as an integer.
>
> Signed-off-by: Marc Ferland <ferlandm@amotus.ca>
> ---
> Changes for v2:
>    - Add commit message

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Stefano Babic Dec. 26, 2020, 3:54 p.m. UTC | #2 
> From: Marc Ferland <ferlandm@amotus.ca>
> Use 0x%2lx to print the i2c bus base address in hexadecimal format
> instead of printing as an integer.
> Signed-off-by: Marc Ferland <ferlandm@amotus.ca>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
index 7609594bd0..d486dab043 100644
--- a/drivers/i2c/mxc_i2c.c
+++ b/drivers/i2c/mxc_i2c.c
@@ -954,7 +954,7 @@  static int mxc_i2c_probe(struct udevice *bus)
 		    !dm_gpio_is_valid(&i2c_bus->scl_gpio) ||
 		    ret || ret2) {
 			dev_err(bus,
-				"i2c bus %d at %lu, fail to request scl/sda gpio\n",
+				"i2c bus %d at 0x%2lx, fail to request scl/sda gpio\n",
 				bus->seq, i2c_bus->base);
 			return -EINVAL;
 		}