diff mbox series

[v3,9/9] IOMUX: Stop dropped consoles

Message ID 20201221123008.9930-9-andriy.shevchenko@linux.intel.com
State Accepted
Commit 70c2525c0d3c5b459ba5a438b23056be648a5249
Delegated to: Tom Rini
Headers show
Series [v3,1/9] console: Introduce console_start() and console_stop() | expand

Commit Message

Andy Shevchenko Dec. 21, 2020, 12:30 p.m. UTC 
When at some point environment shrinks we need to stop dropped devices.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
v3: added tag
 common/iomux.c | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

Comments

Tom Rini Jan. 16, 2021, 4:25 p.m. UTC | #1 
On Mon, Dec 21, 2020 at 02:30:08PM +0200, Andy Shevchenko wrote:

> When at some point environment shrinks we need to stop dropped devices.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/common/iomux.c b/common/iomux.c
index 126d92ce850f..15bf53388559 100644
--- a/common/iomux.c
+++ b/common/iomux.c
@@ -27,8 +27,8 @@  int iomux_doenv(const int console, const char *arg)
 {
 	char *console_args, *temp, **start;
 	int i, j, k, io_flag, cs_idx, repeat;
+	struct stdio_dev **cons_set, **old_set;
 	struct stdio_dev *dev;
-	struct stdio_dev **cons_set;
 
 	console_args = strdup(arg);
 	if (console_args == NULL)
@@ -128,10 +128,23 @@  int iomux_doenv(const int console, const char *arg)
 		return 1;
 	}
 
-	/* Works even if console_devices[console] is NULL. */
-	free(console_devices[console]);
+	old_set = console_devices[console];
+	repeat = cd_count[console];
+
 	console_devices[console] = cons_set;
 	cd_count[console] = cs_idx;
+
+	/* Stop dropped consoles */
+	for (i = 0; i < repeat; i++) {
+		for (j = 0; j < cs_idx; j++) {
+			if (old_set[i] == cons_set[j])
+				break;
+		}
+		if (j == cs_idx)
+			console_stop(console, old_set[i]);
+	}
+
+	free(old_set);
 	return 0;
 }
 #endif /* CONSOLE_MUX */