diff mbox series

[v3] arm: vexpress: don't reset flags in board_init to avoid losing previous ones

Message ID 20201115115410.8747-1-arnaud@intelibre.fr
State Accepted
Commit 5a7885cca50fbc90c52839c4bef0a2cf316ad4fe
Delegated to: Tom Rini
Headers show
Series [v3] arm: vexpress: don't reset flags in board_init to avoid losing previous ones | expand

Commit Message

Arnaud Aujon Chevallier Nov. 15, 2020, 11:54 a.m. UTC
Re-submitted because of missing description and signed-off.

flags reset in board_init caused bugs when executing command like editenv
because the reallocated flag was lost.

Signed-off-by: Arnaud Aujon Chevallier <arnaud@intelibre.fr>

---
 board/armltd/vexpress/vexpress_common.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Michael Opdenacker Nov. 19, 2020, 9:33 a.m. UTC | #1
Tested-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
Tom Rini Nov. 20, 2020, 1:39 a.m. UTC | #2
On Sun, Nov 15, 2020 at 12:54:10PM +0100, Arnaud Aujon Chevallier wrote:

> Re-submitted because of missing description and signed-off.
> 
> flags reset in board_init caused bugs when executing command like editenv
> because the reallocated flag was lost.
> 
> Tested-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> Signed-off-by: Arnaud Aujon Chevallier <arnaud@intelibre.fr>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/board/armltd/vexpress/vexpress_common.c b/board/armltd/vexpress/vexpress_common.c
index 70f6cd80d5..8fea8ff352 100644
--- a/board/armltd/vexpress/vexpress_common.c
+++ b/board/armltd/vexpress/vexpress_common.c
@@ -55,7 +55,6 @@  int board_init(void)
 {
 	gd->bd->bi_boot_params = LINUX_BOOT_PARAM_ADDR;
 	gd->bd->bi_arch_number = MACH_TYPE_VEXPRESS;
-	gd->flags = 0;
 
 	icache_enable();
 	flash__init();