diff mbox series

[21/26] arm: mach-k3: common: Drop main r5 start

Message ID 20201110090602.2255-22-t-kristo@ti.com
State Changes Requested
Delegated to: Lokesh Vutla
Headers show
Series TI J7 SoC HSM Rearch support series | expand

Commit Message

Tero Kristo Nov. 10, 2020, 9:05 a.m. UTC
From: Dave Gerlach <d-gerlach@ti.com>

Only start-up the non-linux remote cores if we are running in legacy
boot mode. HSM rearch is not yet supporting this.

Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
---
 arch/arm/mach-k3/common.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Lokesh Vutla Nov. 16, 2020, 4:24 a.m. UTC | #1
On 10/11/20 2:35 pm, Tero Kristo wrote:
> From: Dave Gerlach <d-gerlach@ti.com>
> 
> Only start-up the non-linux remote cores if we are running in legacy
> boot mode. HSM rearch is not yet supporting this.
> 
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> ---
>  arch/arm/mach-k3/common.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3/common.c
> index 418d053610..5582ea6d7e 100644
> --- a/arch/arm/mach-k3/common.c
> +++ b/arch/arm/mach-k3/common.c
> @@ -211,7 +211,9 @@ void __noreturn jump_to_image_no_args(struct spl_image_info *spl_image)
>  		panic("rproc failed to be initialized (%d)\n", ret);
>  
>  	init_env();
> +#ifdef CONFIG_CLK_TI_SCI

Again. This config ussage is a hack. Can we get a better way to do these things?

Thanks and regards,
Lokesh

>  	start_non_linux_remote_cores();
> +#endif
>  	if (!fit_image_info[IMAGE_ID_DM_FW].image_start)
>  		size = load_firmware("name_mcur5f0_0fw", "addr_mcur5f0_0load",
>  				     &loadaddr);
>
Tero Kristo Nov. 16, 2020, 12:28 p.m. UTC | #2
On 16/11/2020 06:24, Lokesh Vutla wrote:
> 
> 
> On 10/11/20 2:35 pm, Tero Kristo wrote:
>> From: Dave Gerlach <d-gerlach@ti.com>
>>
>> Only start-up the non-linux remote cores if we are running in legacy
>> boot mode. HSM rearch is not yet supporting this.

This one, we can check against DM_FW image presence as it has been 
loaded already.

-Tero

>>
>> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
>> ---
>>   arch/arm/mach-k3/common.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3/common.c
>> index 418d053610..5582ea6d7e 100644
>> --- a/arch/arm/mach-k3/common.c
>> +++ b/arch/arm/mach-k3/common.c
>> @@ -211,7 +211,9 @@ void __noreturn jump_to_image_no_args(struct spl_image_info *spl_image)
>>   		panic("rproc failed to be initialized (%d)\n", ret);
>>   
>>   	init_env();
>> +#ifdef CONFIG_CLK_TI_SCI
> 
> Again. This config ussage is a hack. Can we get a better way to do these things?
> 
> Thanks and regards,
> Lokesh
> 
>>   	start_non_linux_remote_cores();
>> +#endif
>>   	if (!fit_image_info[IMAGE_ID_DM_FW].image_start)
>>   		size = load_firmware("name_mcur5f0_0fw", "addr_mcur5f0_0load",
>>   				     &loadaddr);
>>

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
diff mbox series

Patch

diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3/common.c
index 418d053610..5582ea6d7e 100644
--- a/arch/arm/mach-k3/common.c
+++ b/arch/arm/mach-k3/common.c
@@ -211,7 +211,9 @@  void __noreturn jump_to_image_no_args(struct spl_image_info *spl_image)
 		panic("rproc failed to be initialized (%d)\n", ret);
 
 	init_env();
+#ifdef CONFIG_CLK_TI_SCI
 	start_non_linux_remote_cores();
+#endif
 	if (!fit_image_info[IMAGE_ID_DM_FW].image_start)
 		size = load_firmware("name_mcur5f0_0fw", "addr_mcur5f0_0load",
 				     &loadaddr);