| Message ID | 20200906032615.40448-3-samuel@sholland.org |
|---|---|
| State | Superseded |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | sunxi: binman fixes and SCP firmware support | expand |
On Sat, 5 Sep 2020 at 21:26, Samuel Holland <samuel@sholland.org> wrote: > > Due to an extra level of indentation, the "data" property containing the > FDT was being written repeatedly after every other property in the node. > Move the block up one level, so the property is added exactly once. > > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > tools/binman/etype/fit.py | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/tools/binman/etype/fit.py b/tools/binman/etype/fit.py index c291eb26bad..01fa51367e6 100644 --- a/tools/binman/etype/fit.py +++ b/tools/binman/etype/fit.py @@ -179,10 +179,10 @@ class Entry_fit(Entry): b'SEQ', tools.ToBytes(str(seq + 1))) fsw.property(pname, val) - # Add data for 'fdt' nodes (but not 'config') - if depth == 1 and in_images: - fsw.property('data', - tools.ReadFile(fname)) + # Add data for 'fdt' nodes (but not 'config') + if depth == 1 and in_images: + fsw.property('data', + tools.ReadFile(fname)) else: if self._fdts is None: if self._fit_list_prop:
Due to an extra level of indentation, the "data" property containing the FDT was being written repeatedly after every other property in the node. Move the block up one level, so the property is added exactly once. Signed-off-by: Samuel Holland <samuel@sholland.org> --- tools/binman/etype/fit.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)