| Message ID | 20200522163226.3.I0ed2ec96cb6c0bf952202e468a44e404c578f517@changeid |
|---|---|
| State | Accepted |
| Commit | 281236c728be2b26474fe4bfa0e53cc4c5782617 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | checkpatch.pl: Add features to help improve U-Boot code | expand |
On Fri, May 22, 2020 at 04:32:37PM -0600, Simon Glass wrote: > A common problem when submitting a new uclass is to forget to add sandbox > tests. Add a warning for this. > > Of course tests should always be added for new code, but this one seems to > be missed by nearly every new contributor. > > Signed-off-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 93863c8f086..9dc42520e2d 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2241,6 +2241,12 @@ sub pos_last_openparen { # Checks specific to U-Boot sub u_boot_line { my ($realfile, $line, $herecurr) = @_; + + # ask for a test if a new uclass ID is added + if ($realfile =~ /uclass-id.h/ && $line =~ /^\+/) { + WARN("NEW_UCLASS", + "Possible new uclass - make sure to add a sandbox driver, plus a test in test/dm/<name>.c\n" . $herecurr); + } } sub process {
A common problem when submitting a new uclass is to forget to add sandbox tests. Add a warning for this. Of course tests should always be added for new code, but this one seems to be missed by nearly every new contributor. Signed-off-by: Simon Glass <sjg@chromium.org> --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+)