diff mbox series

[v3,9/9] configs: Enable support for the XHCI controller on RPI4 board (ARM 64-bit)

Message ID 20200512184716.2869-10-s.nawrocki@samsung.com
State Superseded
Delegated to: Matthias Brugger
Headers show
Series USB host support for Raspberry Pi 4 board (64-bit) | expand

Commit Message

Sylwester Nawrocki May 12, 2020, 6:47 p.m. UTC 
This requires enabling BRCMSTB PCIe and XHCI_PCI drivers as well as PCI
and USB commands. To get it working one has to call the following commands:
"pci enum; usb start;", thus such commands have been added to the default
"preboot" environment variable. One has to update their environment if it
is already configured to get this feature working out of the box.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
Changes since v2:
 - rpi_4_32b_defconfig, rpi_4_defconfig changes moved to separate
   patch
Changes since v1:
 - removed unneeded CONFIG_XHCI_64BIT_DWORD_ACCESS_ONLY entry.

Changes since RFC:
 - none.
---
 configs/rpi_arm64_defconfig | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Sylwester Nawrocki May 13, 2020, 9:21 a.m. UTC | #1 
On 12.05.2020 20:47, Sylwester Nawrocki wrote:
> This requires enabling BRCMSTB PCIe and XHCI_PCI drivers as well as PCI
> and USB commands. To get it working one has to call the following commands:
> "pci enum; usb start;", thus such commands have been added to the default
> "preboot" environment variable. One has to update their environment if it
> is already configured to get this feature working out of the box.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> Changes since v2:
>  - rpi_4_32b_defconfig, rpi_4_defconfig changes moved to separate
>    patch

rpi_4_defconfig changes should also be part of $subject patch,
I will fix it in next version.
Matthias Brugger May 24, 2020, 6:30 p.m. UTC | #2 
Hi Sylwester,

On 13/05/2020 11:21, Sylwester Nawrocki wrote:
> On 12.05.2020 20:47, Sylwester Nawrocki wrote:
>> This requires enabling BRCMSTB PCIe and XHCI_PCI drivers as well as PCI
>> and USB commands. To get it working one has to call the following commands:
>> "pci enum; usb start;", thus such commands have been added to the default
>> "preboot" environment variable. One has to update their environment if it
>> is already configured to get this feature working out of the box.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> ---
>> Changes since v2:
>>  - rpi_4_32b_defconfig, rpi_4_defconfig changes moved to separate
>>    patch
> 
> rpi_4_defconfig changes should also be part of $subject patch,
> I will fix it in next version.
> 

Do you plan to send a new version the next days?
I'd like to get this into v2020.07 but we are already late in the development cycle.

Regards,
Matthias
Sylwester Nawrocki May 25, 2020, 9:25 a.m. UTC | #3 
Hi Matthias,

On 24.05.2020 20:30, Matthias Brugger wrote:
> On 13/05/2020 11:21, Sylwester Nawrocki wrote:
>> On 12.05.2020 20:47, Sylwester Nawrocki wrote:
>>> This requires enabling BRCMSTB PCIe and XHCI_PCI drivers as well as PCI
>>> and USB commands. To get it working one has to call the following commands:
>>> "pci enum; usb start;", thus such commands have been added to the default
>>> "preboot" environment variable. One has to update their environment if it
>>> is already configured to get this feature working out of the box.
>>>
>>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>>> ---
>>> Changes since v2:
>>>  - rpi_4_32b_defconfig, rpi_4_defconfig changes moved to separate
>>>    patch
>>
>> rpi_4_defconfig changes should also be part of $subject patch,
>> I will fix it in next version.
> 
> Do you plan to send a new version the next days?
> I'd like to get this into v2020.07 but we are already late in the development cycle.

Sure, I will submit new version today.
diff mbox series

Patch

diff --git a/configs/rpi_arm64_defconfig b/configs/rpi_arm64_defconfig
index fea86be..f12d1e3 100644
--- a/configs/rpi_arm64_defconfig
+++ b/configs/rpi_arm64_defconfig
@@ -7,13 +7,14 @@  CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_USE_PREBOOT=y
-CONFIG_PREBOOT="usb start"
+CONFIG_PREBOOT="pci enum; usb start;"
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_SYS_PROMPT="U-Boot> "
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_MMC=y
+CONFIG_CMD_PCI=y
 CONFIG_CMD_USB=y
 CONFIG_CMD_FS_UUID=y
 CONFIG_OF_BOARD=y
@@ -26,11 +27,16 @@  CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_BCM2835=y
 CONFIG_DM_ETH=y
 CONFIG_BCMGENET=y
+CONFIG_PCI=y
+CONFIG_DM_PCI=y
+CONFIG_PCI_BRCMSTB=y
 CONFIG_PINCTRL=y
 # CONFIG_PINCTRL_GENERIC is not set
 # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
 CONFIG_USB=y
 CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_PCI=y
 CONFIG_USB_DWC2=y
 CONFIG_USB_KEYBOARD=y
 CONFIG_USB_HOST_ETHER=y