diff mbox series

[1/2] arm: dts: k3-am654: Increase OSPI default frequency to 50MHz

Message ID 20200402132913.23245-1-vigneshr@ti.com
State Accepted
Commit d5a1f4f551761773066aa1ba6276036d10bdf75f
Delegated to: Lokesh Vutla
Headers show
Series [1/2] arm: dts: k3-am654: Increase OSPI default frequency to 50MHz | expand

Commit Message

Raghavendra, Vignesh April 2, 2020, 1:29 p.m. UTC
In 1 bit mode OSPI can work at upto 50MHz, this provides before write
performance. Therefore increase frequency from 40MHz to 50MHz

Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
 arch/arm/dts/k3-am654-base-board.dts    | 2 +-
 arch/arm/dts/k3-am654-r5-base-board.dts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Pratyush Yadav April 3, 2020, 7:04 a.m. UTC | #1
On 02/04/20 06:59PM, Vignesh Raghavendra wrote:
> In 1 bit mode OSPI can work at upto 50MHz, this provides before write
						  ^^^^^^^^^^^^^^^^^^^^^
Provides _what_ before write performance? Did you mean "provides better 
write performance"? Same in the second patch too.

> performance. Therefore increase frequency from 40MHz to 50MHz
> 
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
>  arch/arm/dts/k3-am654-base-board.dts    | 2 +-
>  arch/arm/dts/k3-am654-r5-base-board.dts | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/dts/k3-am654-base-board.dts b/arch/arm/dts/k3-am654-base-board.dts
> index 5058b6c88e96..3ebf4af5e47a 100644
> --- a/arch/arm/dts/k3-am654-base-board.dts
> +++ b/arch/arm/dts/k3-am654-base-board.dts
> @@ -191,7 +191,7 @@
>  		reg = <0x0>;
>  		spi-tx-bus-width = <1>;
>  		spi-rx-bus-width = <8>;
> -		spi-max-frequency = <40000000>;
> +		spi-max-frequency = <50000000>;
>  		cdns,tshsl-ns = <60>;
>  		cdns,tsd2d-ns = <60>;
>  		cdns,tchsh-ns = <60>;
> diff --git a/arch/arm/dts/k3-am654-r5-base-board.dts b/arch/arm/dts/k3-am654-r5-base-board.dts
> index 257b56a1b032..e6b78643c197 100644
> --- a/arch/arm/dts/k3-am654-r5-base-board.dts
> +++ b/arch/arm/dts/k3-am654-r5-base-board.dts
> @@ -268,7 +268,7 @@
>  		reg = <0x0>;
>  		spi-tx-bus-width = <1>;
>  		spi-rx-bus-width = <8>;
> -		spi-max-frequency = <40000000>;
> +		spi-max-frequency = <50000000>;
>  		cdns,tshsl-ns = <60>;
>  		cdns,tsd2d-ns = <60>;
>  		cdns,tchsh-ns = <60>;
> -- 
> 2.26.0
>
Lokesh Vutla April 7, 2020, 7:32 a.m. UTC | #2
On 02/04/20 6:59 PM, Vignesh Raghavendra wrote:
> In 1 bit mode OSPI can work at upto 50MHz, this provides before write
> performance. Therefore increase frequency from 40MHz to 50MHz
> 
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>

Fixed the $commit in both the patches and applied to u-boot-ti.

Thanks and regards,
Lokesh
Raghavendra, Vignesh April 7, 2020, 7:40 a.m. UTC | #3
On 07/04/20 1:02 pm, Lokesh Vutla wrote:
> 
> 
> On 02/04/20 6:59 PM, Vignesh Raghavendra wrote:
>> In 1 bit mode OSPI can work at upto 50MHz, this provides before write
>> performance. Therefore increase frequency from 40MHz to 50MHz
>>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> 
> Fixed the $commit in both the patches and applied to u-boot-ti.

Thanks! I was about to respin with fix same.

Regards
Vignesh
diff mbox series

Patch

diff --git a/arch/arm/dts/k3-am654-base-board.dts b/arch/arm/dts/k3-am654-base-board.dts
index 5058b6c88e96..3ebf4af5e47a 100644
--- a/arch/arm/dts/k3-am654-base-board.dts
+++ b/arch/arm/dts/k3-am654-base-board.dts
@@ -191,7 +191,7 @@ 
 		reg = <0x0>;
 		spi-tx-bus-width = <1>;
 		spi-rx-bus-width = <8>;
-		spi-max-frequency = <40000000>;
+		spi-max-frequency = <50000000>;
 		cdns,tshsl-ns = <60>;
 		cdns,tsd2d-ns = <60>;
 		cdns,tchsh-ns = <60>;
diff --git a/arch/arm/dts/k3-am654-r5-base-board.dts b/arch/arm/dts/k3-am654-r5-base-board.dts
index 257b56a1b032..e6b78643c197 100644
--- a/arch/arm/dts/k3-am654-r5-base-board.dts
+++ b/arch/arm/dts/k3-am654-r5-base-board.dts
@@ -268,7 +268,7 @@ 
 		reg = <0x0>;
 		spi-tx-bus-width = <1>;
 		spi-rx-bus-width = <8>;
-		spi-max-frequency = <40000000>;
+		spi-max-frequency = <50000000>;
 		cdns,tshsl-ns = <60>;
 		cdns,tsd2d-ns = <60>;
 		cdns,tchsh-ns = <60>;