| Message ID | 20200319102114.8644-2-patrick.delaunay@st.com |
|---|---|
| State | Superseded |
| Delegated to: | Patrice Chotard |
| Headers | show |
| Series | [1/3] stm32mp1: board: add support of CONFIG_ENV_IS_IN_MMC | expand |
Hi On 3/19/20 11:21 AM, Patrick Delaunay wrote: > Activate env config in SPL with CONFIG_SPL_ENV_SUPPORT > and use CONFIG_IS_ENABLED macro to test the activated > CONFIG_$(SPL_)ENV_IS_IN_... in env_get_location. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > --- > > board/st/stm32mp1/stm32mp1.c | 8 ++++---- > configs/stm32mp15_basic_defconfig | 3 +++ > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c > index effba41ad1..474033d640 100644 > --- a/board/st/stm32mp1/stm32mp1.c > +++ b/board/st/stm32mp1/stm32mp1.c > @@ -785,21 +785,21 @@ enum env_location env_get_location(enum env_operation op, int prio) > return ENVL_UNKNOWN; > > switch (bootmode & TAMP_BOOT_DEVICE_MASK) { > -#ifdef CONFIG_ENV_IS_IN_MMC > +#if CONFIG_IS_ENABLED(ENV_IS_IN_MMC) > case BOOT_FLASH_SD: > case BOOT_FLASH_EMMC: > return ENVL_MMC; > #endif > -#ifdef CONFIG_ENV_IS_IN_EXT4 > +#if CONFIG_IS_ENABLED(ENV_IS_IN_EXT4) > case BOOT_FLASH_SD: > case BOOT_FLASH_EMMC: > return ENVL_EXT4; > #endif > -#ifdef CONFIG_ENV_IS_IN_UBI > +#if CONFIG_IS_ENABLED(ENV_IS_IN_UBI) > case BOOT_FLASH_NAND: > return ENVL_UBI; > #endif > -#ifdef CONFIG_ENV_IS_IN_SPI_FLASH > +#if CONFIG_IS_ENABLED(ENV_IS_IN_SPI_FLASH) > case BOOT_FLASH_NOR: > return ENVL_SPI_FLASH; > #endif > diff --git a/configs/stm32mp15_basic_defconfig b/configs/stm32mp15_basic_defconfig > index dd55a8b632..c63002628c 100644 > --- a/configs/stm32mp15_basic_defconfig > +++ b/configs/stm32mp15_basic_defconfig > @@ -16,6 +16,7 @@ CONFIG_FIT=y > CONFIG_BOOTCOMMAND="run bootcmd_stm32mp" > CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION=y > CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION=3 > +CONFIG_SPL_ENV_SUPPORT=y > CONFIG_SPL_I2C_SUPPORT=y > CONFIG_SPL_MTD_SUPPORT=y > CONFIG_SPL_POWER_SUPPORT=y > @@ -63,6 +64,8 @@ CONFIG_ENV_UBI_PART="UBI" > CONFIG_ENV_UBI_VOLUME="uboot_config" > CONFIG_ENV_UBI_VOLUME_REDUND="uboot_config_r" > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > +# CONFIG_SPL_ENV_IS_NOWHERE is not set > +# CONFIG_SPL_ENV_IS_IN_SPI_FLASH is not set > CONFIG_STM32_ADC=y > CONFIG_DFU_MMC=y > CONFIG_DFU_RAM=y Reviewed-by: Patrice Chotard <patrice.chotard@st.com> Thanks Patrice
diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c index effba41ad1..474033d640 100644 --- a/board/st/stm32mp1/stm32mp1.c +++ b/board/st/stm32mp1/stm32mp1.c @@ -785,21 +785,21 @@ enum env_location env_get_location(enum env_operation op, int prio) return ENVL_UNKNOWN; switch (bootmode & TAMP_BOOT_DEVICE_MASK) { -#ifdef CONFIG_ENV_IS_IN_MMC +#if CONFIG_IS_ENABLED(ENV_IS_IN_MMC) case BOOT_FLASH_SD: case BOOT_FLASH_EMMC: return ENVL_MMC; #endif -#ifdef CONFIG_ENV_IS_IN_EXT4 +#if CONFIG_IS_ENABLED(ENV_IS_IN_EXT4) case BOOT_FLASH_SD: case BOOT_FLASH_EMMC: return ENVL_EXT4; #endif -#ifdef CONFIG_ENV_IS_IN_UBI +#if CONFIG_IS_ENABLED(ENV_IS_IN_UBI) case BOOT_FLASH_NAND: return ENVL_UBI; #endif -#ifdef CONFIG_ENV_IS_IN_SPI_FLASH +#if CONFIG_IS_ENABLED(ENV_IS_IN_SPI_FLASH) case BOOT_FLASH_NOR: return ENVL_SPI_FLASH; #endif diff --git a/configs/stm32mp15_basic_defconfig b/configs/stm32mp15_basic_defconfig index dd55a8b632..c63002628c 100644 --- a/configs/stm32mp15_basic_defconfig +++ b/configs/stm32mp15_basic_defconfig @@ -16,6 +16,7 @@ CONFIG_FIT=y CONFIG_BOOTCOMMAND="run bootcmd_stm32mp" CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION=y CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION=3 +CONFIG_SPL_ENV_SUPPORT=y CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_MTD_SUPPORT=y CONFIG_SPL_POWER_SUPPORT=y @@ -63,6 +64,8 @@ CONFIG_ENV_UBI_PART="UBI" CONFIG_ENV_UBI_VOLUME="uboot_config" CONFIG_ENV_UBI_VOLUME_REDUND="uboot_config_r" CONFIG_SYS_RELOC_GD_ENV_ADDR=y +# CONFIG_SPL_ENV_IS_NOWHERE is not set +# CONFIG_SPL_ENV_IS_IN_SPI_FLASH is not set CONFIG_STM32_ADC=y CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y
Activate env config in SPL with CONFIG_SPL_ENV_SUPPORT and use CONFIG_IS_ENABLED macro to test the activated CONFIG_$(SPL_)ENV_IS_IN_... in env_get_location. Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> --- board/st/stm32mp1/stm32mp1.c | 8 ++++---- configs/stm32mp15_basic_defconfig | 3 +++ 2 files changed, 7 insertions(+), 4 deletions(-)